| Summary: | Add assertions to JSLazyEventListener to help catch the cause of a crash | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
| Component: | WebCore Misc. | Assignee: | Chris Dumez <cdumez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, ap, beidson, commit-queue, dbates, esprehn+autocc, ews-watchlist, ggaren, kangil.han, rniwa, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=197576 https://bugs.webkit.org/show_bug.cgi?id=197696 |
||||||||
| Attachments: |
|
||||||||
|
Description
Chris Dumez
2019-05-06 10:56:22 PDT
Created attachment 369138 [details]
Patch
Comment on attachment 369138 [details] Patch Attachment 369138 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12115355 New failing tests: js/dom/custom-constructors.html Created attachment 369184 [details]
Archive of layout-test-results from ews211 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment on attachment 369138 [details]
Patch
I doubt the windows failure is related.
It crashed, so maybe it is? But can't get a crash log from Windows EWS AFAIK. (In reply to Alexey Proskuryakov from comment #5) > It crashed, so maybe it is? But can't get a crash log from Windows EWS AFAIK. Yes, it crashed but no crash trace and the test in question does not seem to have lazy event listeners. Comment on attachment 369138 [details] Patch Clearing flags on attachment: 369138 Committed r244995: <https://trac.webkit.org/changeset/244995> All reviewed patches have been landed. Closing bug. |