Bug 197617 - Add assertions to JSLazyEventListener to help catch the cause of a crash
Summary: Add assertions to JSLazyEventListener to help catch the cause of a crash
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-06 10:56 PDT by Chris Dumez
Modified: 2019-05-08 10:46 PDT (History)
11 users (show)

See Also:

Attachments
Patch (5.41 KB, patch)
2019-05-06 10:58 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews211 for win-future (13.84 MB, application/zip)
2019-05-06 15:37 PDT, EWS Watchlist 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-05-06 10:56:22 PDT 
Add assertions to JSLazyEventListener to help catch the cause of a crash (rdar://problem/24314027).
Comment 1 Chris Dumez 2019-05-06 10:58:15 PDT 
Created attachment 369138 [details]
Patch
Comment 2 EWS Watchlist 2019-05-06 15:37:40 PDT 
Comment on attachment 369138 [details]
Patch

Attachment 369138 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12115355

New failing tests:
js/dom/custom-constructors.html
Comment 3 EWS Watchlist 2019-05-06 15:37:42 PDT 
Created attachment 369184 [details]
Archive of layout-test-results from ews211 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 4 Chris Dumez 2019-05-06 15:56:42 PDT 
Comment on attachment 369138 [details]
Patch

I doubt the windows failure is related.
Comment 5 Alexey Proskuryakov 2019-05-06 16:45:37 PDT 
It crashed, so maybe it is? But can't get a crash log from Windows EWS AFAIK.
Comment 6 Chris Dumez 2019-05-06 16:50:58 PDT 
(In reply to Alexey Proskuryakov from comment #5)
> It crashed, so maybe it is? But can't get a crash log from Windows EWS AFAIK.

Yes, it crashed but no crash trace and the test in question does not seem to have lazy event listeners.
Comment 7 WebKit Commit Bot 2019-05-06 17:21:31 PDT 
Comment on attachment 369138 [details]
Patch

Clearing flags on attachment: 369138

Committed r244995: <https://trac.webkit.org/changeset/244995>
Comment 8 WebKit Commit Bot 2019-05-06 17:21:33 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-05-06 17:23:58 PDT 
<rdar://problem/50520711>