Bug 197615

Summary: [PlayStation] JSC Stress tests failing due to timezone printing
Product: WebKit Reporter: Stephan Szabo <stephan.szabo>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, don.olmstead, fpizlo, lforschler, ross.kirsling, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ross.kirsling: review+
Patch none

Description Stephan Szabo 2019-05-06 09:38:19 PDT
PlayStation's strftime's "%Z" returns an empty string which results in time strings like "Wed Oct 23 1974 11:45:01 GMT-0700" rather than "Wed Oct 23 1974 11:45:01 GMT-0700 (Pacific Daylight Time)" which causes diff failures with the expectations.
Comment 1 Stephan Szabo 2019-05-06 09:46:41 PDT
Created attachment 369126 [details]
Patch

Adding expectations without the timezone string for these tests on PlayStation.

ChakraCore/test/GlobalFunctions/InternalToString.js
ChakraCore/test/Operators/equals.js
ChakraCore/test/fieldopts/objtypespec-newobj.2.js

The timezone names are being managed in the tests to do PDT/PST to full name conversions, so we could strip them instead, but that seemed like it could lose information useful to test on the other platforms.
Comment 2 Ross Kirsling 2019-05-06 10:06:13 PDT
Comment on attachment 369126 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369126&action=review

> JSTests/ChakraCore.yaml:693
> +          runChakra :baseline, "NoException", "InternalToString.playstation.baseline", []

The bare .baseline files are as-is from ChakraCore, so we should mark this .baseline-jsc.
I can't seem to find a precedent for a platform-specific baseline though -- maybe .baseline-jsc-playstation, so that we keep the more specific stuff at the very end?
Comment 3 Stephan Szabo 2019-05-06 10:53:03 PDT
Created attachment 369137 [details]
Patch

Changing names per review comment.
Comment 4 WebKit Commit Bot 2019-05-06 13:28:00 PDT
Comment on attachment 369137 [details]
Patch

Clearing flags on attachment: 369137

Committed r244972: <https://trac.webkit.org/changeset/244972>
Comment 5 WebKit Commit Bot 2019-05-06 13:28:01 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-05-06 13:28:18 PDT
<rdar://problem/50510575>