Bug 197615

Summary:

[PlayStation] JSC Stress tests failing due to timezone printing

Product:

WebKit

Reporter:

Stephan Szabo <stephan.szabo>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, don.olmstead, fpizlo, lforschler, ross.kirsling, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ross.kirsling: review+
Patch	none

Stephan Szabo

Reported 2019-05-06 09:38:19 PDT

PlayStation's strftime's "%Z" returns an empty string which results in time strings like "Wed Oct 23 1974 11:45:01 GMT-0700" rather than "Wed Oct 23 1974 11:45:01 GMT-0700 (Pacific Daylight Time)" which causes diff failures with the expectations.

Attachments
Patch (547.35 KB, patch) 2019-05-06 09:46 PDT, Stephan Szabo	ross.kirsling: review+	Details Formatted Diff Diff
Patch (547.40 KB, patch) 2019-05-06 10:53 PDT, Stephan Szabo	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Stephan Szabo

Comment 1 2019-05-06 09:46:41 PDT

Created attachment 369126 [details] Patch Adding expectations without the timezone string for these tests on PlayStation. ChakraCore/test/GlobalFunctions/InternalToString.js ChakraCore/test/Operators/equals.js ChakraCore/test/fieldopts/objtypespec-newobj.2.js The timezone names are being managed in the tests to do PDT/PST to full name conversions, so we could strip them instead, but that seemed like it could lose information useful to test on the other platforms.

Ross Kirsling

Comment 2 2019-05-06 10:06:13 PDT

Comment on attachment 369126 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369126&action=review > JSTests/ChakraCore.yaml:693 > + runChakra :baseline, "NoException", "InternalToString.playstation.baseline", [] The bare .baseline files are as-is from ChakraCore, so we should mark this .baseline-jsc. I can't seem to find a precedent for a platform-specific baseline though -- maybe .baseline-jsc-playstation, so that we keep the more specific stuff at the very end?

Stephan Szabo

Comment 3 2019-05-06 10:53:03 PDT

Created attachment 369137 [details] Patch Changing names per review comment.

WebKit Commit Bot

Comment 4 2019-05-06 13:28:00 PDT

Comment on attachment 369137 [details] Patch Clearing flags on attachment: 369137 Committed r244972: <https://trac.webkit.org/changeset/244972>

WebKit Commit Bot

Comment 5 2019-05-06 13:28:01 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 6 2019-05-06 13:28:18 PDT

<rdar://problem/50510575>

Note You need to log in before you can comment on or make changes to this bug.