Bug 197605

Summary: JS2 should print scores for different categories
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, commit-queue, ews-watchlist, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, rniwa, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
ysuzuki: review+
patch none

Saam Barati
Reported 2019-05-05 23:37:28 PDT
...
Attachments
patch (1.83 KB, patch)
2019-05-05 23:42 PDT, Saam Barati 		ysuzuki: review+
DetailsFormatted DiffDiff
patch (3.68 KB, patch)
2019-05-06 12:03 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2019-05-05 23:42:01 PDT
Created attachment 369101 [details] patch
Tadeu Zagallo
Comment 2 2019-05-05 23:48:08 PDT
Why is this only for the CLI? Also, the ChangeLog entry is missing.
Yusuke Suzuki
Comment 3 2019-05-05 23:59:17 PDT
Comment on attachment 369101 [details] patch r=me. As Tadeu said, adding this feature to non-cli version would be also useful too (yeah, it would involve some UI changes... And please add ChangeLog for this.
Saam Barati
Comment 4 2019-05-06 11:34:58 PDT
(In reply to Tadeu Zagallo from comment #2) > Why is this only for the CLI? Also, the ChangeLog entry is missing. If we add it to the website, we should do it behind some kind of key click when we're done running. Let me look into it.
Saam Barati
Comment 5 2019-05-06 12:03:57 PDT
Created attachment 369153 [details] patch
Yusuke Suzuki
Comment 6 2019-05-06 12:17:31 PDT
Comment on attachment 369153 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=369153&action=review r=me > PerformanceTests/JetStream2/JetStreamDriver.js:53 > + for (let [category, scores] of categoryScores) > + summaryElement.innerHTML += `<p> ${category}: ${uiFriendlyNumber(geomean(scores))}</p>` I think sorting the categories is better. > PerformanceTests/JetStream2/JetStreamDriver.js:247 > + for (let [category, scores] of categoryScores) > + console.log(`${category}: ${uiFriendlyNumber(geomean(scores))}`); Ditto.
Saam Barati
Comment 7 2019-05-06 12:27:35 PDT
Comment on attachment 369153 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=369153&action=review >> PerformanceTests/JetStream2/JetStreamDriver.js:53 >> + summaryElement.innerHTML += `<p> ${category}: ${uiFriendlyNumber(geomean(scores))}</p>` > > I think sorting the categories is better. How would you sort it? It's nice now that benchmarks that share sub categories end up printing next to each other.
Yusuke Suzuki
Comment 8 2019-05-06 13:17:54 PDT
Comment on attachment 369153 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=369153&action=review >>> PerformanceTests/JetStream2/JetStreamDriver.js:53 >>> + summaryElement.innerHTML += `<p> ${category}: ${uiFriendlyNumber(geomean(scores))}</p>` >> >> I think sorting the categories is better. > > How would you sort it? It's nice now that benchmarks that share sub categories end up printing next to each other. OK, talked with Saam. The order is kept by ES6 Map.
WebKit Commit Bot
Comment 9 2019-05-06 13:36:46 PDT
Comment on attachment 369153 [details] patch Clearing flags on attachment: 369153 Committed r244973: <https://trac.webkit.org/changeset/244973>
WebKit Commit Bot
Comment 10 2019-05-06 13:36:47 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2019-05-06 13:37:21 PDT
<rdar://problem/50511028>
Note You need to log in before you can comment on or make changes to this bug.