| Summary: | JS2 should print scores for different categories | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||
| Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, cdumez, commit-queue, ews-watchlist, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, rniwa, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Saam Barati
2019-05-05 23:37:28 PDT
Created attachment 369101 [details]
patch
Why is this only for the CLI? Also, the ChangeLog entry is missing. Comment on attachment 369101 [details]
patch
r=me. As Tadeu said, adding this feature to non-cli version would be also useful too (yeah, it would involve some UI changes...
And please add ChangeLog for this.
(In reply to Tadeu Zagallo from comment #2) > Why is this only for the CLI? Also, the ChangeLog entry is missing. If we add it to the website, we should do it behind some kind of key click when we're done running. Let me look into it. Created attachment 369153 [details]
patch
Comment on attachment 369153 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=369153&action=review r=me > PerformanceTests/JetStream2/JetStreamDriver.js:53 > + for (let [category, scores] of categoryScores) > + summaryElement.innerHTML += `<p> ${category}: ${uiFriendlyNumber(geomean(scores))}</p>` I think sorting the categories is better. > PerformanceTests/JetStream2/JetStreamDriver.js:247 > + for (let [category, scores] of categoryScores) > + console.log(`${category}: ${uiFriendlyNumber(geomean(scores))}`); Ditto. Comment on attachment 369153 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=369153&action=review >> PerformanceTests/JetStream2/JetStreamDriver.js:53 >> + summaryElement.innerHTML += `<p> ${category}: ${uiFriendlyNumber(geomean(scores))}</p>` > > I think sorting the categories is better. How would you sort it? It's nice now that benchmarks that share sub categories end up printing next to each other. Comment on attachment 369153 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=369153&action=review >>> PerformanceTests/JetStream2/JetStreamDriver.js:53 >>> + summaryElement.innerHTML += `<p> ${category}: ${uiFriendlyNumber(geomean(scores))}</p>` >> >> I think sorting the categories is better. > > How would you sort it? It's nice now that benchmarks that share sub categories end up printing next to each other. OK, talked with Saam. The order is kept by ES6 Map. Comment on attachment 369153 [details] patch Clearing flags on attachment: 369153 Committed r244973: <https://trac.webkit.org/changeset/244973> All reviewed patches have been landed. Closing bug. |