Bug 197593

Summary:

fast/attachment/attachment-folder-icon.html is an Image Only failure on recent macOS builds

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

WebCore Misc.

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, bdakin, commit-queue, ews-watchlist, megan_gardner, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews213 for win-future	none

Description Wenson Hsieh 2019-05-04 16:47:14 PDT

<rdar://problem/50379267>

Comment 1 Wenson Hsieh 2019-05-04 16:56:18 PDT

Created attachment 369075 [details]
Patch

Comment 2 EWS Watchlist 2019-05-04 20:56:55 PDT Comment hidden (obsolete)

Comment on attachment 369075 [details]
Patch

Attachment 369075 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12102586

New failing tests:
http/tests/security/local-video-src-from-remote.html

Comment 3 EWS Watchlist 2019-05-04 20:56:57 PDT Comment hidden (obsolete)

Created attachment 369084 [details]
Archive of layout-test-results from ews213 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews213  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Comment 4 Tim Horton 2019-05-05 03:18:57 PDT

Comment on attachment 369075 [details]
Patch

Do we need the same change in RenderThemeIOS?

Comment 5 WebKit Commit Bot 2019-05-05 03:45:27 PDT

Comment on attachment 369075 [details]
Patch

Clearing flags on attachment: 369075

Committed r244956: <https://trac.webkit.org/changeset/244956>

Comment 6 WebKit Commit Bot 2019-05-05 03:45:29 PDT

All reviewed patches have been landed.  Closing bug.

Comment 7 Wenson Hsieh 2019-05-05 13:38:47 PDT

(In reply to Tim Horton from comment #4)
> Comment on attachment 369075 [details]
> Patch
> 
> Do we need the same change in RenderThemeIOS?

I don't believe we do, since this logic to convert these MIME types to a UTI for an icon only exists on macOS.

That being said, there is another issue that needs to be addressed, which is that currently, dropping or pasting folders on both macOS and iOS using the new attachments SPI will create attachments with type "public.directory" instead of "public.folder".

I plan to fix this separately.