Bug 197584

Summary: [JSC] Need to emit SetLocal if we emit MovHint in DFGByteCodeParser
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch saam: review+

Yusuke Suzuki
Reported 2019-05-03 16:02:44 PDT
[JSC] Need to emit SetLocal if we emit MovHint in DFGByteCodeParser
Attachments
Patch (8.59 KB, patch)
2019-05-03 16:19 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (7.45 KB, patch)
2019-05-03 16:21 PDT, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-05-03 16:19:26 PDT
Created attachment 369013 [details] Patch
Yusuke Suzuki
Comment 2 2019-05-03 16:21:48 PDT
Created attachment 369014 [details] Patch
Yusuke Suzuki
Comment 3 2019-05-03 16:31:15 PDT
<rdar://problem/50435721>
Saam Barati
Comment 4 2019-05-03 16:46:37 PDT
Comment on attachment 369014 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369014&action=review > Source/JavaScriptCore/ChangeLog:10 > + and SetLocal are needed to be a pair in DFGByteCodeParser because we rely on this assumption in SSA conversion phase. SSA conversion phase always emit KillStack This seems weird.
Saam Barati
Comment 5 2019-05-03 16:47:38 PDT
(In reply to Saam Barati from comment #4) > Comment on attachment 369014 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=369014&action=review > > > Source/JavaScriptCore/ChangeLog:10 > > + and SetLocal are needed to be a pair in DFGByteCodeParser because we rely on this assumption in SSA conversion phase. SSA conversion phase always emit KillStack > > This seems weird. Actually I guess it makes sense. I wonder if we can remove this requirement at some point
Yusuke Suzuki
Comment 6 2019-05-03 16:51:04 PDT
Comment on attachment 369014 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369014&action=review Thanks! >>> Source/JavaScriptCore/ChangeLog:10 >>> + and SetLocal are needed to be a pair in DFGByteCodeParser because we rely on this assumption in SSA conversion phase. SSA conversion phase always emit KillStack >> >> This seems weird. > > Actually I guess it makes sense. I wonder if we can remove this requirement at some point Yeah, we should eventually remove this requirement...
Yusuke Suzuki
Comment 7 2019-05-03 16:57:32 PDT
Committed r244939: <https://trac.webkit.org/changeset/244939>
Note You need to log in before you can comment on or make changes to this bug.