Bug 197583

Summary: [CMake] fuse-ld should also be set in module linker flags
Product: WebKit Reporter: Christopher Reid <chris.reid>
Component: CMakeAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, don.olmstead, ews-watchlist, mcatanzaro, stephan.szabo
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews213 for win-future
none
Patch for landing none

Christopher Reid
Reported 2019-05-03 15:27:54 PDT
I hit an odd linker error when trying to turn on CFI in GTK. -fuse-ld=lld wasn't being set when linking the libWebProcessTest.so module.
Attachments
Patch (2.14 KB, patch)
2019-05-03 16:45 PDT, Christopher Reid 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews213 for win-future (13.76 MB, application/zip)
2019-05-03 23:59 PDT, EWS Watchlist 		no flags
Details
Patch for landing (1.84 KB, patch)
2019-05-06 00:27 PDT, Christopher Reid 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Christopher Reid
Comment 1 2019-05-03 16:45:46 PDT
Created attachment 369021 [details] Patch
Christopher Reid
Comment 2 2019-05-03 23:50:19 PDT
Hm it looks like the GTK build is failing now because --no-undefined was being overwritten when CMAKE_SHARED_LINKER_FLAGS is set to CMAKE_EXE_LINKER_FLAG. I'll take that change out for now.
EWS Watchlist
Comment 3 2019-05-03 23:59:43 PDT
Comment on attachment 369021 [details] Patch Attachment 369021 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12097236 New failing tests: http/tests/css/filters-on-iframes.html
EWS Watchlist
Comment 4 2019-05-03 23:59:46 PDT
Created attachment 369062 [details] Archive of layout-test-results from ews213 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews213 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Christopher Reid
Comment 5 2019-05-06 00:27:21 PDT
Created attachment 369108 [details] Patch for landing
WebKit Commit Bot
Comment 6 2019-05-06 00:54:34 PDT
Comment on attachment 369108 [details] Patch for landing Clearing flags on attachment: 369108 Committed r244960: <https://trac.webkit.org/changeset/244960>
WebKit Commit Bot
Comment 7 2019-05-06 00:54:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.