| Summary: | [CMake] fuse-ld should also be set in module linker flags | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Christopher Reid <chris.reid> | ||||||||
| Component: | CMake | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, don.olmstead, ews-watchlist, mcatanzaro, stephan.szabo | ||||||||
| Priority: | P2 | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Christopher Reid
2019-05-03 15:27:54 PDT
Created attachment 369021 [details]
Patch
Hm it looks like the GTK build is failing now because --no-undefined was being overwritten when CMAKE_SHARED_LINKER_FLAGS is set to CMAKE_EXE_LINKER_FLAG. I'll take that change out for now. Comment on attachment 369021 [details] Patch Attachment 369021 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12097236 New failing tests: http/tests/css/filters-on-iframes.html Created attachment 369062 [details]
Archive of layout-test-results from ews213 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews213 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Created attachment 369108 [details]
Patch for landing
Comment on attachment 369108 [details] Patch for landing Clearing flags on attachment: 369108 Committed r244960: <https://trac.webkit.org/changeset/244960> All reviewed patches have been landed. Closing bug. |