Bug 197581

Summary: Adopt AVStreamDataParser.audiovisualMIMETypes
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Jer Noble
Reported 2019-05-03 15:12:33 PDT
Adopt AVStreamDataParser.audiovisualMIMETypes
Attachments
Patch (41.32 KB, patch)
2019-05-03 15:31 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (47.36 KB, patch)
2019-05-06 11:08 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (47.42 KB, patch)
2019-05-06 12:36 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-05-03 15:12:58 PDT
<rdar://problem/50458981>
Jer Noble
Comment 2 2019-05-03 15:31:03 PDT
Created attachment 369005 [details] Patch
Eric Carlson
Comment 3 2019-05-03 16:11:43 PDT
Comment on attachment 369005 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369005&action=review > Source/WebCore/platform/graphics/avfoundation/objc/AVStreamDataParserMIMETypeCache.mm:77 > + // AVStreamDataParser does not have an -isPlayableExtendedMIMEType: method, so just replace the container type > + // with a valid one from AVAssetMIMETypeCache and ask that cache if it can decode this type: You should add a FIXME to remove this once they implement -isPlayableExtendedMIMEType > Source/WebCore/platform/graphics/avfoundation/objc/AVStreamDataParserMIMETypeCache.mm:81 > + ContentType originalType { mimeType }; Can't you just reuse "type" defined above?
Jer Noble
Comment 4 2019-05-06 10:34:13 PDT
(In reply to Eric Carlson from comment #3) > Comment on attachment 369005 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=369005&action=review > > > Source/WebCore/platform/graphics/avfoundation/objc/AVStreamDataParserMIMETypeCache.mm:77 > > + // AVStreamDataParser does not have an -isPlayableExtendedMIMEType: method, so just replace the container type > > + // with a valid one from AVAssetMIMETypeCache and ask that cache if it can decode this type: > > You should add a FIXME to remove this once they implement > -isPlayableExtendedMIMEType Will do. > > Source/WebCore/platform/graphics/avfoundation/objc/AVStreamDataParserMIMETypeCache.mm:81 > > + ContentType originalType { mimeType }; > > Can't you just reuse "type" defined above? Yep!
Jer Noble
Comment 5 2019-05-06 11:08:48 PDT
Created attachment 369142 [details] Patch for landing
Jer Noble
Comment 6 2019-05-06 12:36:24 PDT
Created attachment 369157 [details] Patch for landing
WebKit Commit Bot
Comment 7 2019-05-06 15:22:32 PDT
Comment on attachment 369157 [details] Patch for landing Clearing flags on attachment: 369157 Committed r244980: <https://trac.webkit.org/changeset/244980>
WebKit Commit Bot
Comment 8 2019-05-06 15:22:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.