| Summary: | [WebAuthN] A focused document should be required | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jiewen Tan <jiewen_tan> | ||||||||||||
| Component: | WebCore Misc. | Assignee: | Jiewen Tan <jiewen_tan> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, ews-watchlist, jiewen_tan, rniwa, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | |||||||||||||||
| Bug Blocks: | 181943 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Jiewen Tan
2019-05-02 18:49:48 PDT
Created attachment 368867 [details]
Patch
Comment on attachment 368867 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368867&action=review > Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:-171 > - // For better performance, transports of options.excludeCredentials are checked in LocalAuthenticator. Why are you removing this comment. At least we should say we aren't implementing these steps and why. > Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:-243 > - if (!m_client) { Ditto. Comment on attachment 368867 [details] Patch Attachment 368867 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12073209 New failing tests: http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https.html Created attachment 368876 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 368867 [details] Patch Attachment 368867 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12073710 New failing tests: http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https.html Created attachment 368884 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.4
Comment on attachment 368867 [details] Patch Attachment 368867 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12076757 New failing tests: svg/repaint/remove-border-property-on-root.html http/tests/css/filters-on-iframes.html Created attachment 368896 [details]
Archive of layout-test-results from ews211 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment on attachment 368867 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368867&action=review Thanks Brent for r+ this patch. >> Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:-171 >> - // For better performance, transports of options.excludeCredentials are checked in LocalAuthenticator. > > Why are you removing this comment. At least we should say we aren't implementing these steps and why. Because all those steps are implemented. Created attachment 368962 [details]
Patch for Landing
Committed r244938: <https://trac.webkit.org/changeset/244938> |