Bug 197540

Summary: Need additional UIPreviewAction information in WKImagePreviewViewController
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
wenson_hsieh: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews215 for win-future none

Dean Jackson
Reported 2019-05-02 18:31:15 PDT
Need additional UIPreviewAction information in WKImagePreviewViewController
Attachments
Patch (2.88 KB, patch)
2019-05-02 18:34 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (2.40 KB, patch)
2019-05-02 19:01 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (2.88 KB, patch)
2019-05-02 19:02 PDT, Dean Jackson 		wenson_hsieh: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews215 for win-future (13.76 MB, application/zip)
2019-05-02 20:01 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-05-02 18:31:52 PDT
<rdar://problem/50430510>
Dean Jackson
Comment 2 2019-05-02 18:34:51 PDT
Created attachment 368863 [details] Patch
Dean Jackson
Comment 3 2019-05-02 19:01:28 PDT
Created attachment 368865 [details] Patch
Dean Jackson
Comment 4 2019-05-02 19:02:35 PDT
Created attachment 368866 [details] Patch
EWS Watchlist
Comment 5 2019-05-02 20:01:34 PDT
Comment on attachment 368866 [details] Patch Attachment 368866 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12073213 New failing tests: svg/dynamic-updates/SVGLinearGradientElement-svgdom-href-prop.html
EWS Watchlist
Comment 6 2019-05-02 20:01:36 PDT
Created attachment 368874 [details] Archive of layout-test-results from ews215 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews215 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Wenson Hsieh
Comment 7 2019-05-02 22:00:13 PDT
Comment on attachment 368866 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368866&action=review > Source/WebKit/UIProcess/WKImagePreviewViewController.mm:38 > +#define ADDITIONAL_PREVIEW_ACTION_ITEM_INFO Nit - you might want to consider making this a method or function instead of a macro.
Dean Jackson
Comment 8 2019-05-03 12:35:28 PDT
Committed r244916: <https://trac.webkit.org/changeset/244916>
Note You need to log in before you can comment on or make changes to this bug.