| Summary: | Need additional UIPreviewAction information in WKImagePreviewViewController | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||||||||
| Component: | New Bugs | Assignee: | Dean Jackson <dino> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | ews-watchlist, webkit-bug-importer, wenson_hsieh | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Dean Jackson
2019-05-02 18:31:15 PDT
Created attachment 368863 [details]
Patch
Created attachment 368865 [details]
Patch
Created attachment 368866 [details]
Patch
Comment on attachment 368866 [details] Patch Attachment 368866 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12073213 New failing tests: svg/dynamic-updates/SVGLinearGradientElement-svgdom-href-prop.html Created attachment 368874 [details]
Archive of layout-test-results from ews215 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews215 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment on attachment 368866 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368866&action=review > Source/WebKit/UIProcess/WKImagePreviewViewController.mm:38 > +#define ADDITIONAL_PREVIEW_ACTION_ITEM_INFO Nit - you might want to consider making this a method or function instead of a macro. Committed r244916: <https://trac.webkit.org/changeset/244916> |