Bug 197539

Summary:

Provide UIImages for element actions

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

New Bugs

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	wenson_hsieh: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews210 for win-future	none

Dean Jackson

Reported 2019-05-02 18:24:24 PDT

Provide UIImages for element actions

Attachments
Patch (2.42 KB, patch) 2019-05-02 18:29 PDT, Dean Jackson	no flags	Details Formatted Diff Diff
Patch (2.40 KB, patch) 2019-05-02 19:03 PDT, Dean Jackson	wenson_hsieh: review+ ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews210 for win-future (13.82 MB, application/zip) 2019-05-02 20:03 PDT, EWS Watchlist	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2019-05-02 18:25:09 PDT

<rdar://problem/50430363>

Dean Jackson

Comment 2 2019-05-02 18:29:07 PDT

Created attachment 368861 [details] Patch

Dean Jackson

Comment 3 2019-05-02 19:03:15 PDT

Created attachment 368868 [details] Patch

EWS Watchlist

Comment 4 2019-05-02 20:03:14 PDT

Comment on attachment 368868 [details] Patch Attachment 368868 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12073262 New failing tests: svg/dynamic-updates/SVGLinearGradientElement-svgdom-href-prop.html security/contentSecurityPolicy/video-with-file-url-allowed-by-media-src-star-with-AllowContentSecurityPolicySourceStarToMatchAnyProtocol-enabled.html

EWS Watchlist

Comment 5 2019-05-02 20:03:16 PDT

Created attachment 368875 [details] Archive of layout-test-results from ews210 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews210 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Wenson Hsieh

Comment 6 2019-05-02 21:59:24 PDT

Comment on attachment 368868 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368868&action=review > Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.h:30 > +#import <UIKit/UIImage.h> Nit - I think you can get away with just @class UIImage;

Dean Jackson

Comment 7 2019-05-03 11:53:05 PDT

Committed r244914: <https://trac.webkit.org/changeset/244914>

Note You need to log in before you can comment on or make changes to this bug.