Bug 19749

Summary: Merge inc/dec halves of PrefixBracketNode and PostfixBracketNode
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Patch to merge inc/dec halves of PrefixBracketNode and PostfixBracketNode
sam: review+
updated sam: review+

Gavin Barraclough
Reported 2008-06-24 09:14:28 PDT
Post Squirrelfish there is no longer a performance gain in having separate nodes for inc and dec – merging these will simplify & reduce code duplication in the parse tree. Patch following.
Attachments
Patch to merge inc/dec halves of PrefixBracketNode and PostfixBracketNode (9.74 KB, patch)
2008-06-24 09:15 PDT, Gavin Barraclough 		sam: review+
DetailsFormatted DiffDiff
updated (10.41 KB, patch)
2008-07-16 17:50 PDT, Gavin Barraclough 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2008-06-24 09:15:12 PDT
Created attachment 21907 [details] Patch to merge inc/dec halves of PrefixBracketNode and PostfixBracketNode
Sam Weinig
Comment 2 2008-06-24 20:37:55 PDT
Comment on attachment 21907 [details] Patch to merge inc/dec halves of PrefixBracketNode and PostfixBracketNode Nice job! r=me.
Gavin Barraclough
Comment 3 2008-07-16 17:50:38 PDT
Created attachment 22326 [details] updated Enough of a conflict I thought I should put a new patch up.
Gavin Barraclough
Comment 4 2008-07-17 04:47:55 PDT
Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/kjs/grammar.y Sending JavaScriptCore/kjs/nodes.cpp Sending JavaScriptCore/kjs/nodes.h Sending JavaScriptCore/kjs/nodes2string.cpp Transmitting file data ..... Committed revision 35218.
Note You need to log in before you can comment on or make changes to this bug.