Bug 197470

Summary:

Web Inspector: Audit: make it easier to jump to any returned DOM node in the Elements tab

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=197591

Bug Depends on:

190754

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
[Image] After Patch is applied (Inline)	none
[Image] After Patch is applied (Expanded)	none
Patch	none

Description Devin Rousso 2019-05-01 12:23:16 PDT

When returning DOM nodes via `domNodes`, there's no "obvious" way (there's a context menu option) to jump to the live location of that DOM node in the DOM tree (e.g. in the Elements tab).

Comment 1 Devin Rousso 2019-05-03 22:13:49 PDT

Created attachment 369050 [details]
Patch

Comment 2 Radar WebKit Bug Importer 2019-05-03 22:14:00 PDT

<rdar://problem/50466773>

Comment 3 Radar WebKit Bug Importer 2019-05-03 22:14:00 PDT

<rdar://problem/50466774>

Comment 4 Devin Rousso 2019-05-03 22:17:45 PDT

Created attachment 369052 [details]
Patch

Split `WI.TreeElement` fix into a separate bug 197591.

Comment 5 Joseph Pecoraro 2019-05-17 16:12:25 PDT

Comment on attachment 369052 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369052&action=review

r=me

> Source/WebInspectorUI/ChangeLog:18
> +        Provide a way to insert a go-to arrow right after the:

Should include a screenshot of what this looks like to make review easier.

Comment 6 Devin Rousso 2019-05-17 21:18:19 PDT

Created attachment 370180 [details]
[Image] After Patch is applied (Inline)

Comment 7 Devin Rousso 2019-05-17 21:18:40 PDT

Created attachment 370181 [details]
[Image] After Patch is applied (Expanded)

Comment 8 Devin Rousso 2019-05-17 21:22:00 PDT

Created attachment 370182 [details]
Patch

Comment 9 WebKit Commit Bot 2019-05-17 22:10:35 PDT

Comment on attachment 370182 [details]
Patch

Clearing flags on attachment: 370182

Committed r245497: <https://trac.webkit.org/changeset/245497>

Comment 10 WebKit Commit Bot 2019-05-17 22:10:37 PDT

All reviewed patches have been landed.  Closing bug.