Summary: | Merge inc/dec halves of PrefixDotNode and PostfixDotNode | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gavin Barraclough <barraclough> | ||||||||||
Component: | JavaScriptCore | Assignee: | Gavin Barraclough <barraclough> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | ||||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Mac | ||||||||||||
OS: | OS X 10.5 | ||||||||||||
Attachments: |
|
Description
Gavin Barraclough
2008-06-24 08:56:00 PDT
Created attachment 21906 [details]
Patch to merge inc/dec halves of PrefixDotNode and PostfixDotNode
Comment on attachment 21906 [details]
Patch to merge inc/dec halves of PrefixDotNode and PostfixDotNode
Nice job! A couple of nits on style.
Some white space issue here.
+ virtual RegisterID* emitCode(CodeGenerator&, RegisterID* = 0) KJS_FAST_CALL;
+ virtual void streamTo(SourceStream&) const KJS_FAST_CALL;
Here too.
+ Operator m_operator;
+ };
r=me if you fix those issues.
Created attachment 21928 [details]
Eeep! - fix for whitespace error.
Comment on attachment 21928 [details]
Eeep! - fix for whitespace error.
Very nice!
Created attachment 22323 [details]
merged up for commit
Enough of a conflict I thought I should put a new patch up.
Created attachment 22328 [details]
fix to the update
Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/kjs/grammar.y Sending JavaScriptCore/kjs/nodes.cpp Sending JavaScriptCore/kjs/nodes.h Sending JavaScriptCore/kjs/nodes2string.cpp Transmitting file data ..... Committed revision 35224. |