Bug 19747

Summary:

Merge inc/dec halves of PrefixDotNode and PostfixDotNode

Product:

WebKit

Reporter:

Gavin Barraclough <barraclough>

Component:

JavaScriptCore

Assignee:

Gavin Barraclough <barraclough>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
Patch to merge inc/dec halves of PrefixDotNode and PostfixDotNode	sam: review+
Eeep! - fix for whitespace error.	sam: review+
merged up for commit	sam: review+
fix to the update	sam: review+

Gavin Barraclough

Reported 2008-06-24 08:56:00 PDT

Post Squirrelfish there is no longer a performance gain in having separate nodes for inc and dec – merging these will simplify & reduce code duplication in the parse tree. Patch following.

Attachments
Patch to merge inc/dec halves of PrefixDotNode and PostfixDotNode (9.01 KB, patch) 2008-06-24 08:57 PDT, Gavin Barraclough	sam: review+	Details Formatted Diff Diff
Eeep! - fix for whitespace error. (8.99 KB, patch) 2008-06-25 08:06 PDT, Gavin Barraclough	sam: review+	Details Formatted Diff Diff
merged up for commit (6.60 KB, patch) 2008-07-16 17:31 PDT, Gavin Barraclough	sam: review+	Details Formatted Diff Diff
fix to the update (9.73 KB, patch) 2008-07-16 19:26 PDT, Gavin Barraclough	sam: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Gavin Barraclough

Comment 1 2008-06-24 08:57:40 PDT

Created attachment 21906 [details] Patch to merge inc/dec halves of PrefixDotNode and PostfixDotNode

Sam Weinig

Comment 2 2008-06-24 20:35:42 PDT

Comment on attachment 21906 [details] Patch to merge inc/dec halves of PrefixDotNode and PostfixDotNode Nice job! A couple of nits on style. Some white space issue here. + virtual RegisterID* emitCode(CodeGenerator&, RegisterID* = 0) KJS_FAST_CALL; + virtual void streamTo(SourceStream&) const KJS_FAST_CALL; Here too. + Operator m_operator; + }; r=me if you fix those issues.

Gavin Barraclough

Comment 3 2008-06-25 08:06:40 PDT

Created attachment 21928 [details] Eeep! - fix for whitespace error.

Sam Weinig

Comment 4 2008-06-25 10:29:01 PDT

Comment on attachment 21928 [details] Eeep! - fix for whitespace error. Very nice!

Gavin Barraclough

Comment 5 2008-07-16 17:31:43 PDT

Created attachment 22323 [details] merged up for commit Enough of a conflict I thought I should put a new patch up.

Gavin Barraclough

Comment 6 2008-07-16 19:26:10 PDT

Created attachment 22328 [details] fix to the update

Gavin Barraclough

Comment 7 2008-07-17 12:35:18 PDT

Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/kjs/grammar.y Sending JavaScriptCore/kjs/nodes.cpp Sending JavaScriptCore/kjs/nodes.h Sending JavaScriptCore/kjs/nodes2string.cpp Transmitting file data ..... Committed revision 35224.

Note You need to log in before you can comment on or make changes to this bug.