| Summary: | [iOS] Star rating is covered with a black circle when writing a review on Yelp | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, dino, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer, zalan | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
zalan
2019-05-01 11:58:29 PDT
Created attachment 368695 [details]
Patch
This might just be temp if we decide to move more style painting from RenderTheme to html.css after resolving the "where is this style coming from" question to support -webkit-appearance: none. Comment on attachment 368695 [details] Patch Clearing flags on attachment: 368695 Committed r244848: <https://trac.webkit.org/changeset/244848> All reviewed patches have been landed. Closing bug. This change caused layout test failures on iOS simulator. It looks like EWS caught the failures, but it didn't finish verifying results. Regressions: Unexpected text-only failures (4) compositing/overflow/theme-affects-visual-overflow.html [ Failure ] fast/block/margin-collapse/103.html [ Failure ] fast/parser/bad-xml-slash.html [ Failure ] tables/mozilla/bugs/bug4527.html [ Failure ] https://build.webkit.org/results/Apple%20iOS%2012%20Simulator%20Release%20WK2%20(Tests)/r244848%20(3881)/results.html (In reply to Ryan Haddad from comment #5) > This change caused layout test failures on iOS simulator. It looks like EWS > caught the failures, but it didn't finish verifying results. > > Regressions: Unexpected text-only failures (4) > compositing/overflow/theme-affects-visual-overflow.html [ Failure ] > fast/block/margin-collapse/103.html [ Failure ] > fast/parser/bad-xml-slash.html [ Failure ] > tables/mozilla/bugs/bug4527.html [ Failure ] > > https://build.webkit.org/results/ > Apple%20iOS%2012%20Simulator%20Release%20WK2%20(Tests)/r244848%20(3881)/ > results.html Thanks, will rebaseline them. https://trac.webkit.org/changeset/244855/webkit should take care of them. |