Bug 197423

Summary: [ews-build] Parse and display bindings test failures
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, ews-watchlist, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Aakash Jain 2019-04-30 10:54:44 PDT
Bindings tests queue should parse the test failures from the json output, and include that information in step and build status.
Comment 1 Aakash Jain 2019-04-30 10:56:13 PDT
Created attachment 368578 [details]
Patch
Comment 2 Aakash Jain 2019-04-30 11:00:16 PDT
Sample runs: 
Patch with bindings test failures: https://ews-build.webkit-uat.org/#/builders/21/builds/4802
Patch without bindings test failures: https://ews-build.webkit-uat.org/#/builders/21/builds/4801
Comment 3 Lucas Forschler 2019-04-30 11:06:34 PDT
Comment on attachment 368578 [details]
Patch

lgtm... I'm curious about the timeout. how long do these normally take to run?
Comment 4 Aakash Jain 2019-04-30 11:13:08 PDT
> lgtm... I'm curious about the timeout. how long do these normally take to run?
Usually takes a minute or two to run. Timeout is for the amount of time without any output, in case the script/machine is hanging/slow for any reason.
Comment 5 EWS Watchlist 2019-04-30 11:14:58 PDT Comment hidden (obsolete)
Comment 6 WebKit Commit Bot 2019-04-30 11:33:35 PDT
Comment on attachment 368578 [details]
Patch

Clearing flags on attachment: 368578

Committed r244789: <https://trac.webkit.org/changeset/244789>
Comment 7 WebKit Commit Bot 2019-04-30 11:33:37 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-04-30 11:34:21 PDT
<rdar://problem/50343367>