Bug 197395

Summary:

[ews-build] Parse and display webkitpy failures

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, commit-queue, ews-watchlist, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Aakash Jain

Reported 2019-04-29 16:55:01 PDT

WebKitPy queue should parse the test failures from the json output, and include that information in step and build status.

Attachments
Patch (3.55 KB, patch) 2019-04-29 16:57 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2019-04-29 16:57:46 PDT

Created attachment 368516 [details] Patch

EWS Watchlist

Comment 2 2019-04-29 16:59:23 PDT Comment hidden (obsolete)

Attachment 368516 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:499: [RunWebKitPyTests.getResultSummary] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:499: [RunWebKitPyTests.getResultSummary] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:500: [RunWebKitPyTests.getResultSummary] Instance of 'RunWebKitPyTests' has no 'results' member [pylint/E1101] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:375: [TestWebKitPyTests.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:375: [TestWebKitPyTests.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 5 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alexey Proskuryakov

Comment 3 2019-04-29 19:39:15 PDT

Comment on attachment 368516 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368516&action=review > Tools/ChangeLog:3 > + [ews-build] Parse and display webkitpy failures Python tests support JSON output. What is missing from it that requires parsing?

Aakash Jain

Comment 4 2019-04-30 03:24:09 PDT

(In reply to Alexey Proskuryakov from comment #3) > Python tests support JSON output. What is missing from it that requires parsing? After running the tests, buildbot needs to read that JSON output, and set the build and step status strings which would contain the failing test names. This would also make the status bubble tooltip display the failing test names.

WebKit Commit Bot

Comment 5 2019-04-30 07:51:18 PDT

Comment on attachment 368516 [details] Patch Clearing flags on attachment: 368516 Committed r244769: <https://trac.webkit.org/changeset/244769>

WebKit Commit Bot

Comment 6 2019-04-30 07:51:20 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 7 2019-04-30 07:52:18 PDT

<rdar://problem/50334787>

Note You need to log in before you can comment on or make changes to this bug.