Bug 197395 – [ews-build] Parse and display webkitpy failures

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

WebKitPy queue should parse the test failures from the json output, and include that information in step and build status.

[Aakash Jain]

Created attachment 368516 [details]
Patch

[EWS Watchlist]

Attachment 368516 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:499:  [RunWebKitPyTests.getResultSummary] Use of super on an old style class  [pylint/E1002] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:499:  [RunWebKitPyTests.getResultSummary] Use of super on an old style class  [pylint/E1002] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:500:  [RunWebKitPyTests.getResultSummary] Instance of 'RunWebKitPyTests' has no 'results' member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:375:  [TestWebKitPyTests.test_success] Passing unexpected keyword argument 'state_string' in function call  [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:375:  [TestWebKitPyTests.test_success] No value passed for parameter 'status_text' in function call  [pylint/E1120] [5]
Total errors found: 5 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alexey Proskuryakov]

Comment on attachment 368516 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368516&action=review

> Tools/ChangeLog:3
> +        [ews-build] Parse and display webkitpy failures

Python tests support JSON output. What is missing from it that requires parsing?

[Aakash Jain]

(In reply to Alexey Proskuryakov from comment #3)
> Python tests support JSON output. What is missing from it that requires parsing?
After running the tests, buildbot needs to read that JSON output, and set the build and step status strings which would contain the failing test names. This would also make the status bubble tooltip display the failing test names.

[WebKit Commit Bot]

Comment on attachment 368516 [details]
Patch

Clearing flags on attachment: 368516

Committed r244769: <https://trac.webkit.org/changeset/244769>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/50334787>