Bug 197395 - [ews-build] Parse and display webkitpy failures
Summary: [ews-build] Parse and display webkitpy failures
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-29 16:55 PDT by Aakash Jain
Modified: 2019-04-30 07:52 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.55 KB, patch)
2019-04-29 16:57 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-04-29 16:55:01 PDT
WebKitPy queue should parse the test failures from the json output, and include that information in step and build status.
Comment 1 Aakash Jain 2019-04-29 16:57:46 PDT
Created attachment 368516 [details]
Patch
Comment 2 Build Bot 2019-04-29 16:59:23 PDT Comment hidden (obsolete)
Comment 3 Alexey Proskuryakov 2019-04-29 19:39:15 PDT
Comment on attachment 368516 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368516&action=review

> Tools/ChangeLog:3
> +        [ews-build] Parse and display webkitpy failures

Python tests support JSON output. What is missing from it that requires parsing?
Comment 4 Aakash Jain 2019-04-30 03:24:09 PDT
(In reply to Alexey Proskuryakov from comment #3)
> Python tests support JSON output. What is missing from it that requires parsing?
After running the tests, buildbot needs to read that JSON output, and set the build and step status strings which would contain the failing test names. This would also make the status bubble tooltip display the failing test names.
Comment 5 WebKit Commit Bot 2019-04-30 07:51:18 PDT
Comment on attachment 368516 [details]
Patch

Clearing flags on attachment: 368516

Committed r244769: <https://trac.webkit.org/changeset/244769>
Comment 6 WebKit Commit Bot 2019-04-30 07:51:20 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-04-30 07:52:18 PDT
<rdar://problem/50334787>