Summary: | [Flatpak] webkit-build fails due to missing GTK2 in build environment | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adrian Perez <aperez> | ||||
Component: | Tools / Tests | Assignee: | Adrian Perez <aperez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, lforschler, mcatanzaro, pnormand, tsaunier, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Adrian Perez
2019-04-28 08:07:36 PDT
As a workaround, once can use instead: % build-webkit --gtk --cmakeargs='-DENABLE_PLUGIN_PROCESS_GTK2=OFF' but in my opinion developers should not need to pass anything special to “build-webkit” to get a vanilla build done with the usual development compilation options. From what I understand, this is because the Flatpak SDK is not shipping GTK2 anymore, which means we have two ways to go about this: a.) Add GTK2 to our local build manifest. b.) When building inside the Flatpak environment, automatically disable the GTK2 plugin process. While I would prefer to to (b.) —and in the long run that is what will happen— at the moment we support the option, and threfore I think that we should routinely build with the option enabled to make sure the code does not bitrot, so right now I think we should go for (a.). That's weird, because we never had GTK2 in gnome-build-meta. Created attachment 369282 [details]
Patch
Comment on attachment 369282 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369282&action=review > Tools/flatpak/org.webkit.GTK.yaml:101 > + config-opts: Can examples also be disabled? (In reply to Philippe Normand from comment #4) > Comment on attachment 369282 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=369282&action=review > > > Tools/flatpak/org.webkit.GTK.yaml:101 > > + config-opts: > > Can examples also be disabled? Unfortunately, there is no flag in the autotools configure script to disable the examples :-/ Comment on attachment 369282 [details] Patch Clearing flags on attachment: 369282 Committed r245011: <https://trac.webkit.org/changeset/245011> All reviewed patches have been landed. Closing bug. |