Bug 197336

Summary: Storage::deleteOldVersions does not need to retain Storage
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cgarcia, darin, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=197406
Attachments:
Description Flags
Patch darin: review+

Description Alex Christensen 2019-04-26 18:07:25 PDT 
Storage::deleteOldVersions does not need to retain Storage
Comment 1 Alex Christensen 2019-04-26 18:08:25 PDT 
Created attachment 368373 [details]
Patch
Comment 2 Alex Christensen 2019-04-26 18:08:28 PDT 
<rdar://problem/48679972>
Comment 3 Alex Christensen 2019-04-29 13:32:59 PDT 
http://trac.webkit.org/r244750
Comment 4 Chris Dumez 2019-04-29 14:09:07 PDT 
Comment on attachment 368373 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368373&action=review

> Source/WebKit/ChangeLog:5
> +        <rdar://problem/48679972>

How does this bug explain <rdar://problem/48679972> ? What's the CompletionHandler that crashes here?
Comment 5 Alex Christensen 2019-04-29 15:28:46 PDT 
rdar://problem/47759337 not rdar://problem/48679972
Comment 6 Alex Christensen 2019-04-29 15:40:24 PDT 
Hmmm, now I'm not sure.  I definitely saw the destructor of this lambda being the cause of a crash but now I can't find it.