| Summary: | JSWrapperMap should check if existing prototype properties are wrappers when copying exported methods. | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||||||||
| Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, mark.lam, msaboff, saam, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Keith Miller
2019-04-26 14:06:24 PDT
Created attachment 368567 [details]
Patch
Created attachment 368569 [details]
Patch
Comment on attachment 368569 [details] Patch Attachment 368569 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12041744 New failing tests: webaudio/oscillator-ended.html Created attachment 368577 [details]
Archive of layout-test-results from ews117 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 368569 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368569&action=review r=me > Source/JavaScriptCore/ChangeLog:12 > + property. Normally this would only happen if a Objective-C super a => an > Source/JavaScriptCore/ChangeLog:15 > + Object.protype the overriden method won't be exported. protype => prototype > Source/JavaScriptCore/API/JSWrapperMap.mm:274 > + bool hasProperty = jsObject->getPropertySlot(exec, JSC::Identifier::fromString(exec, String(name)), slot); what about exceptions? Maybe you wanted VMInquiry above? > Source/JavaScriptCore/API/tests/testapi.mm:2541 > +- (BOOL)other; is this needed? Created attachment 369211 [details]
Patch for landing
Comment on attachment 369211 [details] Patch for landing Clearing flags on attachment: 369211 Committed r244999: <https://trac.webkit.org/changeset/244999> All reviewed patches have been landed. Closing bug. |