Bug 197298

Summary: webkitpy: Including skipped tests in the final count
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, ews-watchlist, glenn, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jonathan Bedard
Reported 2019-04-25 15:23:35 PDT
Lucas pointed out to me that upon completion of a layout test run, we will print out a description of how many tests passed vs the total number of tests. The problem with this metric is that the total number of tests includes the tests rightfully skipped because they are not run on the specified port.
Attachments
Patch (1.34 KB, patch)
2019-04-25 15:55 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2019-04-25 15:24:05 PDT
<rdar://problem/49705424>
Jonathan Bedard
Comment 2 2019-04-25 15:55:03 PDT
Created attachment 368280 [details] Patch
WebKit Commit Bot
Comment 3 2019-04-25 17:17:45 PDT
Comment on attachment 368280 [details] Patch Clearing flags on attachment: 368280 Committed r244671: <https://trac.webkit.org/changeset/244671>
WebKit Commit Bot
Comment 4 2019-04-25 17:17:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.