Bug 197259

Summary: Add SPI to set HSTS storage directory
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2019-04-24 16:25:40 PDT
Add SPI to set HSTS storage directory
Attachments
Patch (11.73 KB, patch)
2019-04-24 16:51 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (11.90 KB, patch)
2019-05-07 16:59 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-04-24 16:51:34 PDT
Created attachment 368200 [details] Patch
Alex Christensen
Comment 2 2019-04-24 16:51:37 PDT
<rdar://problem/48797895>
Alex Christensen
Comment 3 2019-04-24 17:08:29 PDT
Note: requested test SPI here: rdar://problem/50188304
Alex Christensen
Comment 4 2019-05-07 16:59:42 PDT
Created attachment 369335 [details] Patch
Alex Christensen
Comment 5 2019-05-07 17:01:45 PDT
Comment on attachment 369335 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369335&action=review This is ready for review. > Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:73 > +@property (nonatomic, nullable, copy, setter=setHSTSStorageDirectory:) NSURL *hstsStorageDirectory WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); I made this an NSURL instead of an NSString to match other directories on _WKWebsiteDataStoreConfiguration.
WebKit Commit Bot
Comment 6 2019-05-08 16:12:01 PDT
Comment on attachment 369335 [details] Patch Clearing flags on attachment: 369335 Committed r245075: <https://trac.webkit.org/changeset/245075>
WebKit Commit Bot
Comment 7 2019-05-08 16:12:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.