Summary: | Add SPI to set HSTS storage directory | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | beidson, benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, webkit-bug-importer, youennf | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Alex Christensen
2019-04-24 16:25:40 PDT
Created attachment 368200 [details]
Patch
Note: requested test SPI here: rdar://problem/50188304 Created attachment 369335 [details]
Patch
Comment on attachment 369335 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369335&action=review This is ready for review. > Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:73 > +@property (nonatomic, nullable, copy, setter=setHSTSStorageDirectory:) NSURL *hstsStorageDirectory WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); I made this an NSURL instead of an NSString to match other directories on _WKWebsiteDataStoreConfiguration. Comment on attachment 369335 [details] Patch Clearing flags on attachment: 369335 Committed r245075: <https://trac.webkit.org/changeset/245075> All reviewed patches have been landed. Closing bug. |