Bug 197243

Summary: [RemoteInspector] Fix connection and target identifier types.
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: PlatformAssignee: Basuke Suzuki <basuke>
Status: RESOLVED FIXED    
Severity: Normal CC: basuke, commit-queue, don.olmstead, ews-watchlist, hi, joepeck, keith_miller, mark.lam, mcatanzaro, msaboff, ross.kirsling, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
PATCH
none
PATCH
none
Test for GTK/WPE and Mac/iOS build
none
Patch for landing none

Basuke Suzuki
Reported 2019-04-24 13:50:49 PDT
The type ClientID and connection id delivered in the event body is interchangeable so that they have to be same type.
Attachments
PATCH (23.24 KB, patch)
2019-04-24 14:01 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
PATCH (43.86 KB, patch)
2019-04-24 15:21 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
Test for GTK/WPE and Mac/iOS build (39.12 KB, patch)
2019-04-24 15:46 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch for landing (44.21 KB, patch)
2019-04-25 11:03 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2019-04-24 14:01:12 PDT
Created attachment 368174 [details] PATCH
Don Olmstead
Comment 2 2019-04-24 14:20:40 PDT
Comment on attachment 368174 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=368174&action=review > Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorConnectionClient.cpp:65 > + unsigned targetID; Do you want to do the same to TargetID while you're here?
Basuke Suzuki
Comment 3 2019-04-24 14:32:14 PDT
Sure.
Basuke Suzuki
Comment 4 2019-04-24 15:21:34 PDT
Created attachment 368189 [details] PATCH
Ross Kirsling
Comment 5 2019-04-24 15:33:00 PDT
Comment on attachment 368189 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=368189&action=review > Source/JavaScriptCore/inspector/remote/RemoteControllableTarget.h:41 > +using TargetID = unsigned; Should this be changed to uint32_t as well?
Basuke Suzuki
Comment 6 2019-04-24 15:41:46 PDT
(In reply to Ross Kirsling from comment #5) > Comment on attachment 368189 [details] > PATCH > > View in context: > https://bugs.webkit.org/attachment.cgi?id=368189&action=review > > > Source/JavaScriptCore/inspector/remote/RemoteControllableTarget.h:41 > > +using TargetID = unsigned; > > Should this be changed to uint32_t as well? I intentionally leave that as is because there's no assumption that `unsigned` is uint32_t (of course it is correct for known compilers).
Basuke Suzuki
Comment 7 2019-04-24 15:46:10 PDT
Created attachment 368193 [details] Test for GTK/WPE and Mac/iOS build
Basuke Suzuki
Comment 8 2019-04-25 11:03:56 PDT
Created attachment 368249 [details] Patch for landing
WebKit Commit Bot
Comment 9 2019-04-25 11:54:23 PDT
Comment on attachment 368249 [details] Patch for landing Clearing flags on attachment: 368249 Committed r244657: <https://trac.webkit.org/changeset/244657>
WebKit Commit Bot
Comment 10 2019-04-25 11:54:24 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2019-04-25 11:55:35 PDT
<rdar://problem/50213703>
Note You need to log in before you can comment on or make changes to this bug.