Bug 197231

Summary: Rename _highlightLongPressCanClick and only add gesture recognizer when necessary
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: graouts, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch graouts: review+

Dean Jackson
Reported 2019-04-24 04:55:34 PDT
Rename _highlightLongPressCanClick and only add gesture recognizer when necessary
Attachments
Patch (6.08 KB, patch)
2019-04-24 05:00 PDT, Dean Jackson 		graouts: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-04-24 04:56:31 PDT
<rdar://problem/50164234>
Dean Jackson
Comment 2 2019-04-24 05:00:48 PDT
Created attachment 368119 [details] Patch
Antoine Quint
Comment 3 2019-04-24 05:15:14 PDT
Comment on attachment 368119 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368119&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:756 > + } Maybe I'm not used to this kind of use of a block, but this looks a bit nasty to have this code only be conditionalized with a build-time flag. Could we have this wrapped in a function with an early return if the build-time flag and condition are as expected?
Dean Jackson
Comment 4 2019-04-24 05:24:01 PDT
Committed r244586: <https://trac.webkit.org/changeset/244586>
Note You need to log in before you can comment on or make changes to this bug.