Bug 197194

Summary: [ews-build] Use explicit imports instead of wildcard imports
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, dewei_zhu, jbedard, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Aakash Jain
Reported 2019-04-23 06:27:45 PDT
PEP8 says: "Wildcard imports (from <module> import *) should be avoided, as they make it unclear which names are present in the namespace, confusing both readers and many automated tools." https://www.python.org/dev/peps/pep-0008/ We should remove wildcard imports and use explicit imports.
Attachments
Patch (4.36 KB, patch)
2019-04-23 06:31 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-04-23 06:31:37 PDT
Created attachment 368025 [details] Patch
WebKit Commit Bot
Comment 2 2019-04-23 10:54:40 PDT
Comment on attachment 368025 [details] Patch Clearing flags on attachment: 368025 Committed r244549: <https://trac.webkit.org/changeset/244549>
WebKit Commit Bot
Comment 3 2019-04-23 10:54:42 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2019-04-23 10:55:37 PDT
<rdar://problem/50135923>
Note You need to log in before you can comment on or make changes to this bug.