Bug 197194

Summary:

[ews-build] Use explicit imports instead of wildcard imports

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, commit-queue, dewei_zhu, jbedard, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Aakash Jain 2019-04-23 06:27:45 PDT

PEP8 says: "Wildcard imports (from <module> import *) should be avoided, as they make it unclear which names are present in the namespace, confusing both readers and many automated tools."

https://www.python.org/dev/peps/pep-0008/

We should remove wildcard imports and use explicit imports.

Comment 1 Aakash Jain 2019-04-23 06:31:37 PDT

Created attachment 368025 [details]
Patch

Comment 2 WebKit Commit Bot 2019-04-23 10:54:40 PDT

Comment on attachment 368025 [details]
Patch

Clearing flags on attachment: 368025

Committed r244549: <https://trac.webkit.org/changeset/244549>

Comment 3 WebKit Commit Bot 2019-04-23 10:54:42 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Radar WebKit Bug Importer 2019-04-23 10:55:37 PDT

<rdar://problem/50135923>