Bug 197188

Summary: [iOS] element.focus() sometimes fails to reveal the focused element when it becomes editable dynamically
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cmarcelo, dbates, esprehn+autocc, ews-watchlist, kangil.han, megan_gardner, simon.fraser, thorton, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 197145    
Bug Blocks:    
Attachments:
Description Flags
Fixes the bug wenson_hsieh: review+

Ryosuke Niwa
Reported 2019-04-22 23:24:27 PDT
When an element becomes editable and then immediately focused via element.focus(), WebKit fails to reveal the element due to the conflicts between scroll-to-reveal code in WeCore / WebContent process and UI process. <rdar://problem/43613941>
Attachments
Fixes the bug (8.70 KB, patch)
2019-04-22 23:38 PDT, Ryosuke Niwa 		wenson_hsieh: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2019-04-22 23:38:54 PDT
Created attachment 368015 [details] Fixes the bug
Wenson Hsieh
Comment 2 2019-04-23 07:57:32 PDT
Comment on attachment 368015 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=368015&action=review > Source/WebCore/ChangeLog:8 > + The bug was caused by the scroll-to-reveal code trgiggered by Element::updateFocusAppearance updating Nit - "trgiggered" => triggered > Source/WebCore/ChangeLog:10 > + _zoomToRevealFocusedElement in WKWebContent view had already scrolled the frame view. Nit - "WKWebContent view" => WKContentView
Ryosuke Niwa
Comment 3 2019-04-23 10:10:13 PDT
Committed r244546: <https://trac.webkit.org/changeset/244546>
Note You need to log in before you can comment on or make changes to this bug.