| Summary: | Action sheet shares a stringified URL instead of a URL object | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, bdakin, commit-queue, darin, ews-watchlist, megan_gardner, simon.fraser, webkit-bug-importer, wenson_hsieh | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Tim Horton
2019-04-22 19:11:33 PDT
Created attachment 368005 [details]
Patch
Comment on attachment 368005 [details] Patch Attachment 368005 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11968287 New failing tests: webgl/2.0.0/conformance/context/context-release-upon-reload.html Created attachment 368009 [details]
Archive of layout-test-results from ews112 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 368005 [details]
Patch
No unit test?
Comment on attachment 368005 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368005&action=review > Source/WebKit/ChangeLog:18 > + Make it possible to optionally provide WKShareSheet with > + a rect to present relative to. Why doesn’t this bug title mention this second change? Is it related in some non-obvious way? (In reply to Darin Adler from comment #6) > Comment on attachment 368005 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=368005&action=review > > > Source/WebKit/ChangeLog:18 > > + Make it possible to optionally provide WKShareSheet with > > + a rect to present relative to. > > Why doesn’t this bug title mention this second change? Is it related in some > non-obvious way? It is necessary in order to make the first change without regressing the popover tail on iPad (WKShareSheet previously would just center itself in the window, but the text selection assistant took a rect to pass through, like WKShareSheet does now). Comment on attachment 368005 [details] Patch Clearing flags on attachment: 368005 Committed r244553: <https://trac.webkit.org/changeset/244553> All reviewed patches have been landed. Closing bug. |