Bug 197182

Summary:

[ews-build] Improve summary for UploadBuiltProduct step

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, dewei_zhu, ews-watchlist, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	lforschler: review+

Aakash Jain

Reported 2019-04-22 16:26:14 PDT

The summary automatically generated by Buildbot for UploadBuiltProduct step (which uses Buildbot base class git.Git) is 'uploading release.zip'. We should improve this.

Attachments
Patch (3.72 KB, patch) 2019-04-22 16:29 PDT, Aakash Jain	lforschler: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2019-04-22 16:29:17 PDT

Created attachment 367993 [details] Patch

EWS Watchlist

Comment 2 2019-04-22 16:31:40 PDT Comment hidden (obsolete)

Attachment 367993 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:678: [UploadBuiltProduct.getResultSummary] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:679: [UploadBuiltProduct.getResultSummary] Instance of 'UploadBuiltProduct' has no 'results' member [pylint/E1101] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:892: [TestUploadBuiltProduct.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:892: [TestUploadBuiltProduct.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:913: [TestUploadBuiltProduct.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:913: [TestUploadBuiltProduct.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 6 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.

Aakash Jain

Comment 3 2019-04-22 16:36:45 PDT

(In reply to Aakash Jain from comment #0) > (which uses Buildbot base class git.Git) typo here. base class is transfer.FileUpload.

Aakash Jain

Comment 4 2019-04-22 17:22:09 PDT

Committed r244533: <https://trac.webkit.org/changeset/244533>

Radar WebKit Bug Importer

Comment 5 2019-04-22 17:23:29 PDT

<rdar://problem/50113946>

Note You need to log in before you can comment on or make changes to this bug.