| Summary: | [ews-build] Improve summary for UploadBuiltProduct step | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ap, dewei_zhu, ews-watchlist, lforschler, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Aakash Jain
2019-04-22 16:26:14 PDT
Created attachment 367993 [details]
Patch
Attachment 367993 [details] did not pass style-queue:
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:678: [UploadBuiltProduct.getResultSummary] Use of super on an old style class [pylint/E1002] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:679: [UploadBuiltProduct.getResultSummary] Instance of 'UploadBuiltProduct' has no 'results' member [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:892: [TestUploadBuiltProduct.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:892: [TestUploadBuiltProduct.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:913: [TestUploadBuiltProduct.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:913: [TestUploadBuiltProduct.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5]
Total errors found: 6 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to Aakash Jain from comment #0) > (which uses Buildbot base class git.Git) typo here. base class is transfer.FileUpload. Committed r244533: <https://trac.webkit.org/changeset/244533> |