Bug 197182 – [ews-build] Improve summary for UploadBuiltProduct step

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

The summary automatically generated by Buildbot for UploadBuiltProduct step (which uses Buildbot base class git.Git) is 'uploading release.zip'. We should improve this.

[Aakash Jain]

Created attachment 367993 [details]
Patch

[EWS Watchlist]

Attachment 367993 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:678:  [UploadBuiltProduct.getResultSummary] Use of super on an old style class  [pylint/E1002] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:679:  [UploadBuiltProduct.getResultSummary] Instance of 'UploadBuiltProduct' has no 'results' member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:892:  [TestUploadBuiltProduct.test_success] Passing unexpected keyword argument 'state_string' in function call  [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:892:  [TestUploadBuiltProduct.test_success] No value passed for parameter 'status_text' in function call  [pylint/E1120] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:913:  [TestUploadBuiltProduct.test_failure] Passing unexpected keyword argument 'state_string' in function call  [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:913:  [TestUploadBuiltProduct.test_failure] No value passed for parameter 'status_text' in function call  [pylint/E1120] [5]
Total errors found: 6 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Aakash Jain]

(In reply to Aakash Jain from comment #0)
> (which uses Buildbot base class git.Git)
typo here. base class is transfer.FileUpload.

[Aakash Jain]

Committed r244533: <https://trac.webkit.org/changeset/244533>

[Radar WebKit Bug Importer]

<rdar://problem/50113946>