Summary: | [ews-build] Trigger queues only after uploading the archive | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aakash_jain, ap, commit-queue, dewei_zhu, ews-watchlist, lforschler, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Aakash Jain
2019-04-22 15:53:30 PDT
Created attachment 367989 [details]
Patch
Attachment 367989 [details] did not pass style-queue:
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:46: [ConfigureBuild.__init__] Use of super on an old style class [pylint/E1002] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:390: [Trigger.__init__] Use of super on an old style class [pylint/E1002] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:697: [UploadBuiltProduct.finished] Use of super on an old style class [pylint/E1002] [5]
Total errors found: 3 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 367989 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367989&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:394 > + def propertiesToPassToTriggers(self): how about renaming this to triggerProperties? otherwise, lgtm! Comment on attachment 367989 [details] Patch Clearing flags on attachment: 367989 Committed r244532: <https://trac.webkit.org/changeset/244532> All reviewed patches have been landed. Closing bug. |