Bug 197169

Summary:

Deprecate WKContextCreateWithInjectedBundlePath

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, thorton, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Alex Christensen

Reported 2019-04-22 11:19:20 PDT

Deprecate WKContextCreateWithInjectedBundlePath

Attachments
Patch (1.43 KB, patch) 2019-04-22 11:20 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (3.36 KB, patch) 2019-04-22 16:32 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2019-04-22 11:20:58 PDT

Created attachment 367955 [details] Patch

youenn fablet

Comment 2 2019-04-22 14:47:48 PDT

Comment on attachment 367955 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367955&action=review > Source/WebKit/UIProcess/API/C/WKContext.h:110 > +WK_EXPORT WKContextRef WKContextCreateWithInjectedBundlePath(WKStringRef path) WK_C_API_DEPRECATED_WITH_REPLACEMENT(WKContextCreateWithConfiguration); Should we also remove our internal use of WKContextCreateWithInjectedBundlePath in API tests?

Alex Christensen

Comment 3 2019-04-22 14:50:27 PDT

Good catch. I'll do that, too.

Alex Christensen

Comment 4 2019-04-22 16:32:04 PDT

Created attachment 367994 [details] Patch

WebKit Commit Bot

Comment 5 2019-04-22 17:15:09 PDT

Comment on attachment 367994 [details] Patch Clearing flags on attachment: 367994 Committed r244529: <https://trac.webkit.org/changeset/244529>

WebKit Commit Bot

Comment 6 2019-04-22 17:15:11 PDT

All reviewed patches have been landed. Closing bug.