Bug 197169 - Deprecate WKContextCreateWithInjectedBundlePath
Summary: Deprecate WKContextCreateWithInjectedBundlePath
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-22 11:19 PDT by Alex Christensen
Modified: 2019-04-29 21:44 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.43 KB, patch)
2019-04-22 11:20 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (3.36 KB, patch)
2019-04-22 16:32 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-04-22 11:19:20 PDT 
Deprecate WKContextCreateWithInjectedBundlePath
Comment 1 Alex Christensen 2019-04-22 11:20:58 PDT 
Created attachment 367955 [details]
Patch
Comment 2 youenn fablet 2019-04-22 14:47:48 PDT 
Comment on attachment 367955 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367955&action=review

> Source/WebKit/UIProcess/API/C/WKContext.h:110
> +WK_EXPORT WKContextRef WKContextCreateWithInjectedBundlePath(WKStringRef path) WK_C_API_DEPRECATED_WITH_REPLACEMENT(WKContextCreateWithConfiguration);

Should we also remove our internal use of WKContextCreateWithInjectedBundlePath in API tests?
Comment 3 Alex Christensen 2019-04-22 14:50:27 PDT 
Good catch.  I'll do that, too.
Comment 4 Alex Christensen 2019-04-22 16:32:04 PDT 
Created attachment 367994 [details]
Patch
Comment 5 WebKit Commit Bot 2019-04-22 17:15:09 PDT 
Comment on attachment 367994 [details]
Patch

Clearing flags on attachment: 367994

Committed r244529: <https://trac.webkit.org/changeset/244529>
Comment 6 WebKit Commit Bot 2019-04-22 17:15:11 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-04-22 17:16:14 PDT 
<rdar://problem/50113767>
Comment 8 Alex Christensen 2019-04-29 21:44:24 PDT 
See rdar://problem/50323967