Bug 197163

Summary: [GLib] Remove unused MainThreadSharedTimer RunLoopSourcePriority value
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED INVALID    
Severity: Normal CC: benjamin, cdumez, cgarcia, cmarcelo, dbates, ews-watchlist
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Zan Dobersek
Reported 2019-04-22 09:53:29 PDT
[GLib] Remove unused MainThreadSharedTimer RunLoopSourcePriority value
Attachments
Patch (1.54 KB, patch)
2019-04-22 09:54 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2019-04-22 09:54:40 PDT
Created attachment 367946 [details] Patch
Carlos Garcia Campos
Comment 2 2019-04-23 03:15:13 PDT
Comment on attachment 367946 [details] Patch I think this is actually a typo in Source/WTF/wtf/generic/MainThreadGeneric.cpp, it should use MainThreadSharedTimer instead of MainThreadDispatcherTimer. It doesn't matter because we use the same priority but we might change it in the future. MainThreadDispatcherTimer is the priority for timers used to send tasks to the main thread run loop like callOnMainThread().
Zan Dobersek
Comment 3 2019-05-06 00:44:32 PDT
Comment on attachment 367946 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367946&action=review > Source/WTF/wtf/glib/RunLoopSourcePriority.h:-58 > - // WebCore timers. > - MainThreadSharedTimer = 100, Per this comment, MainThreadSharedTimer priority should be used in the WebCore::MainThreadSharedTimer class.
Zan Dobersek
Comment 4 2019-05-06 00:49:03 PDT
Continued in bug #197606.
Note You need to log in before you can comment on or make changes to this bug.