| Summary: | [GLib] Remove unused MainThreadSharedTimer RunLoopSourcePriority value | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||
| Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||
| Status: | RESOLVED INVALID | ||||||
| Severity: | Normal | CC: | benjamin, cdumez, cgarcia, cmarcelo, dbates, ews-watchlist | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Zan Dobersek
2019-04-22 09:53:29 PDT
Created attachment 367946 [details]
Patch
Comment on attachment 367946 [details]
Patch
I think this is actually a typo in Source/WTF/wtf/generic/MainThreadGeneric.cpp, it should use MainThreadSharedTimer instead of MainThreadDispatcherTimer. It doesn't matter because we use the same priority but we might change it in the future. MainThreadDispatcherTimer is the priority for timers used to send tasks to the main thread run loop like callOnMainThread().
Comment on attachment 367946 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367946&action=review > Source/WTF/wtf/glib/RunLoopSourcePriority.h:-58 > - // WebCore timers. > - MainThreadSharedTimer = 100, Per this comment, MainThreadSharedTimer priority should be used in the WebCore::MainThreadSharedTimer class. Continued in bug #197606. |