Summary: | Using CSS wide keywords as a fallback for variable substitution works inconsistently. | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Emilio Cobos Álvarez (:emilio) <emilio> | ||||||||||
Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jbedard, macpherson, menard, sam, twilco.o, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Emilio Cobos Álvarez (:emilio)
2019-04-22 08:36:48 PDT
I'm fixing Firefox (which doesn't support wide keywords altogether) in https://bugzilla.mozilla.org/show_bug.cgi?id=1544886 Created attachment 410552 [details]
Patch
Created attachment 410678 [details]
Patch
Comment on attachment 410678 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410678&action=review > Source/WebCore/css/parser/CSSPropertyParser.cpp:296 > + if (value) Can value ever be null here? Comment on attachment 410678 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410678&action=review >> Source/WebCore/css/parser/CSSPropertyParser.cpp:296 >> + if (value) > > Can value ever be null here? It can’t and this if statement can be removed. > Source/WebCore/css/parser/CSSPropertyParser.cpp:304 > + if (RefPtr<CSSValue> value = maybeConsumeCSSWideKeyword(parser.m_range)) auto > Source/WebCore/css/parser/CSSPropertyParser.cpp:369 > + RefPtr<CSSValue> value = maybeConsumeCSSWideKeyword(rangeCopy); auto Created attachment 410724 [details]
Patch
Committed r268157: <https://trac.webkit.org/changeset/268157> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410724 [details]. |