Bug 197158 – Using CSS wide keywords as a fallback for variable substitution works inconsistently.

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Emilio Cobos Álvarez (:emilio)]

Created attachment 367940 [details]
Testcase.

STR: Open the attached test-case.

Expected result:

A 10px border of the initial color.

Actual result:

The border is transparent, but if I change `color: var(--unknown, initial)` by just `initial`, then it works. So `var(--unknown, inherit)` works but `var(--unknown, initial)` doesn't. I don't see why they should be different.

Chromium has the same bug: https://bugs.chromium.org/p/chromium/issues/detail?id=954963

[Emilio Cobos Álvarez (:emilio)]

I'm fixing Firefox (which doesn't support wide keywords altogether) in https://bugzilla.mozilla.org/show_bug.cgi?id=1544886

[Tyler Wilcock]

Created attachment 410552 [details]
Patch

[Tyler Wilcock]

Created attachment 410678 [details]
Patch

[Sam Weinig]

Comment on attachment 410678 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410678&action=review

> Source/WebCore/css/parser/CSSPropertyParser.cpp:296
> +    if (value)

Can value ever be null here?

[Darin Adler]

Comment on attachment 410678 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410678&action=review

>> Source/WebCore/css/parser/CSSPropertyParser.cpp:296
>> +    if (value)
> 
> Can value ever be null here?

It can’t and this if statement can be removed.

> Source/WebCore/css/parser/CSSPropertyParser.cpp:304
> +    if (RefPtr<CSSValue> value = maybeConsumeCSSWideKeyword(parser.m_range))

auto

> Source/WebCore/css/parser/CSSPropertyParser.cpp:369
> +    RefPtr<CSSValue> value = maybeConsumeCSSWideKeyword(rangeCopy);

auto

[Tyler Wilcock]

Created attachment 410724 [details]
Patch

[EWS]

Committed r268157: <https://trac.webkit.org/changeset/268157>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410724 [details].

[Radar WebKit Bug Importer]

<rdar://problem/70068414>