Bug 197156

Summary:

[GTK] MiniBrowser: also set the passed bg-color when receiving arguments

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bugs-noreply, ews-watchlist, lforschler, mcatanzaro, webkit-bug-importer

Priority:

Keywords:

Gtk, InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=196912

Attachments:

Description	Flags
Patch	mcatanzaro: review+

Description Carlos Garcia Campos 2019-04-22 03:57:42 PDT

The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs support was added.

Comment 1 Carlos Garcia Campos 2019-04-22 04:07:07 PDT

Created attachment 367935 [details]
Patch

Comment 2 EWS Watchlist 2019-04-22 04:08:55 PDT

Attachment 367935 [details] did not pass style-queue:


ERROR: Tools/MiniBrowser/gtk/BrowserTab.h:57:  browser_tab_set_background_color is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Tools/MiniBrowser/gtk/BrowserTab.c:607:  browser_tab_set_background_color is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Michael Catanzaro 2019-04-22 08:58:39 PDT

Please add these files to the style checker whitelist.

Comment 4 Carlos Garcia Campos 2019-04-24 00:54:04 PDT

Committed r244583: <https://trac.webkit.org/changeset/244583>

Comment 5 Radar WebKit Bug Importer 2019-04-24 00:55:18 PDT

<rdar://problem/50159645>