Bug 197153

Summary:

[JSC] useJIT should subsume useRegExpJIT

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	achristensen: review+

Description Yusuke Suzuki 2019-04-22 02:45:10 PDT

[JSC] useJIT should subsume useRegExpJIT

Comment 1 Yusuke Suzuki 2019-04-22 02:45:56 PDT

Created attachment 367930 [details]
Patch

Comment 2 EWS Watchlist 2019-04-22 02:48:21 PDT

Attachment 367930 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/RegExp.cpp:261:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/runtime/RegExp.cpp:319:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Yusuke Suzuki 2019-04-22 11:30:37 PDT

Committed r244505: <https://trac.webkit.org/changeset/244505>

Comment 4 Radar WebKit Bug Importer 2019-04-22 11:31:41 PDT

<rdar://problem/50100848>

Comment 5 Yusuke Suzuki 2019-05-10 09:18:40 PDT

This improved some memory footprint in useJIT=false environment since, perviously, even if useJIT=false is specified, we still have useRegExpJIT=false, and  we attempt to initialize ExecutableAllocator and being rejected by entitlements. Now we do not do that.