| Summary: | Defer EditorState updates until the next layer tree flush in a few additional circumstances | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||
| Component: | HTML Editing | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ap, bdakin, commit-queue, darin, rniwa, simon.fraser, thorton, tsavell, webkit-bug-importer, wenson_hsieh | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=199196 https://bugs.webkit.org/show_bug.cgi?id=199213 |
||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 197188 | ||||||
| Attachments: |
|
||||||
|
Description
Wenson Hsieh
2019-04-20 23:41:57 PDT
Created attachment 367904 [details]
Patch
Comment on attachment 367904 [details]
Patch
Thanks for the review!
Comment on attachment 367904 [details] Patch Clearing flags on attachment: 367904 Committed r244494: <https://trac.webkit.org/changeset/244494> All reviewed patches have been landed. Closing bug. It looks like the changes in https://trac.webkit.org/changeset/244494/webkit has caused the test editing/pasteboard/5761530-1.html to become flakey. I was able to reproduce this using command: run-webkit-tests editing/pasteboard/5761530-1.html --iterations 20 --ios-simulator The test passes on 244493 and with fail on 244494 History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=editing%2Fpasteboard%2F5761530-1.html Diff: --- /Volumes/Data/slave/ios-simulator-12-release-tests-wk2/build/layout-test-results/editing/pasteboard/5761530-1-expected.txt +++ /Volumes/Data/slave/ios-simulator-12-release-tests-wk2/build/layout-test-results/editing/pasteboard/5761530-1-actual.txt @@ -1,3 +1,3 @@ This tests to see that tabs are put into tab spans when they are copied individually. The pasted tab should be inside of a tab span, not a style span. To run the test manually, paste and then inspect the editable region, and ensure that there is a tab span at the beginning of the editable div. -<span class="Apple-tab-span" style="white-space: pre;"> </span><span class="Apple-tab-span" style="white-space:pre;"> </span>xxx +<span class="Apple-tab-span" style="white-space: pre;"> </span><span class="Apple-tab-span" style="white-space:pre;"> </span>xxx That's rather surprising. The test doesn't seem like it would depend anything related to EditorState. Filed https://bugs.webkit.org/show_bug.cgi?id=197438 to track the test flakiness. EWS did hit this failure, but since it is flaky, it wasn't reported. Perhaps we could eventually develop some logic for EWS to dig into flaky failures. |