Bug 197122

Summary:

Use RetainPtr and rename +autocorrectionRectsWithRects:lastRect: to +autocorrectionRectsWithFirstCGRect:lastCGRect:

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebKit Misc.

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

iPhone / iPad

OS:

iOS 12

Attachments:

Description	Flags
Patch	none

Daniel Bates

Reported 2019-04-19 14:55:31 PDT

Smarter code uses smart pointers :) (Sounded better in my head) and why not rename +autocorrectionRectsWithRects to autocorrectionRectsWithCGRects to make it clear what kinds of rects we expect: CGRects of course!

Attachments
Patch (5.46 KB, patch) 2019-04-19 15:17 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2019-04-19 15:00:57 PDT

I still don't like the name.... +autocorrectionRectsWithCGRects... hmm.

Daniel Bates

Comment 2 2019-04-19 15:02:09 PDT

+autocorrectionRectsWithFirstCGRect:lastCGRect:?

Daniel Bates

Comment 3 2019-04-19 15:17:59 PDT

Created attachment 367841 [details] Patch Went with +autocorrectionRectsWithFirstCGRect:lastCGRect:. It is a bit more verbose than I would like. I would need to understand the purpose of these rects to have a chance at a coming up with a better name I think.

Daniel Bates

Comment 4 2019-04-19 16:49:13 PDT

Comment on attachment 367841 [details] Patch Clearing flags on attachment: 367841 Committed r244474: <https://trac.webkit.org/changeset/244474>

Daniel Bates

Comment 5 2019-04-19 16:49:14 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 6 2019-04-19 16:50:20 PDT

<rdar://problem/50064037>

Note You need to log in before you can comment on or make changes to this bug.