Bug 197106

Summary: Eagerly parse immediately invoked functions
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED WONTFIX    
Severity: Normal CC: benjamin, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, mjs, msaboff, rmorisset, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 206706    
Bug Blocks:    
Attachments:
Description Flags
WIP
none
WIP
none
WIP
none
WIP
none
WIP none

Saam Barati
Reported 2019-04-19 10:36:25 PDT
We should develop a heuristic around doing this. This will help parsing time for such code because we won't spend the extra time syntax checking.
Attachments
WIP (48.24 KB, patch)
2020-01-25 12:00 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
WIP (53.13 KB, patch)
2020-01-27 18:11 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
WIP (53.22 KB, patch)
2020-01-27 18:40 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
WIP (55.75 KB, patch)
2020-01-28 15:17 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
WIP (57.44 KB, patch)
2020-01-29 17:58 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-04-19 10:41:33 PDT
<rdar://problem/50052023>
Saam Barati
Comment 2 2019-10-20 21:56:35 PDT
*** Bug 202674 has been marked as a duplicate of this bug. ***
Saam Barati
Comment 3 2020-01-23 12:09:20 PST
Gonna give this a go
Saam Barati
Comment 4 2020-01-25 12:00:41 PST
Created attachment 388785 [details] WIP it begins
Saam Barati
Comment 5 2020-01-27 18:11:14 PST
Created attachment 388954 [details] WIP it eagerly parsed something, but crashed in emitting debug info
Saam Barati
Comment 6 2020-01-27 18:40:29 PST
Created attachment 388957 [details] WIP no longer crashing in emitExpressionInfo
Saam Barati
Comment 7 2020-01-28 15:17:36 PST
Created attachment 389073 [details] WIP seems to work for functions.
Saam Barati
Comment 8 2020-01-29 11:17:05 PST
Seems neutral on major benchmarks. It is a speedup on microbenchmarks
Saam Barati
Comment 9 2020-01-29 17:58:22 PST
Created attachment 389208 [details] WIP Seems to work, but isn't really a speedup :(
Note You need to log in before you can comment on or make changes to this bug.