Summary: | Need to add Localizable.strigsdict to WebCore | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | yevseytsev <yevseytsev> | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED INVALID | ||||||
Severity: | Normal | CC: | achristensen, aestes, ap, ews-watchlist, thorton | ||||
Priority: | P2 | ||||||
Version: | Safari 12 | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
yevseytsev
2019-04-18 13:44:20 PDT
https://bugs.webkit.org/show_bug.cgi?id=197014 requires this to be implemented Created attachment 367796 [details]
Patch
Attachment 367796 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 367796 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367796&action=review > Source/WebCore/ChangeLog:15 > + * testing/LocalizedStringsdictTest.swift: Added. Unfortunately I don't think we can use Swift in WebKit right now. We actually have it already, Source/WebCore/en.lproj/Localizable.stringsdict |