Bug 197070

Summary: Need to add Localizable.strigsdict to WebCore
Product: WebKit Reporter: yevseytsev <yevseytsev>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: achristensen, aestes, ap, ews, thorton
Priority: P2    
Version: Safari 12   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch achristensen: review-

Description yevseytsev 2019-04-18 13:44:20 PDT
We need to have Localizable.strigsdict in WebCore, because in many languages pluralization rules are not as simple as in English (adding 's' at the end of the word). I want to work on it
Comment 1 yevseytsev 2019-04-18 13:45:53 PDT
https://bugs.webkit.org/show_bug.cgi?id=197014
requires this to be implemented
Comment 2 yevseytsev 2019-04-19 06:46:47 PDT
Created attachment 367796 [details]
Patch
Comment 3 Build Bot 2019-04-19 06:48:15 PDT
Attachment 367796 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Alex Christensen 2019-04-22 09:59:06 PDT
Comment on attachment 367796 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367796&action=review

> Source/WebCore/ChangeLog:15
> +        * testing/LocalizedStringsdictTest.swift: Added.

Unfortunately I don't think we can use Swift in WebKit right now.
Comment 5 Alexey Proskuryakov 2019-05-09 15:55:34 PDT
We actually have it already, Source/WebCore/en.lproj/Localizable.stringsdict