Bug 197066

Summary: Remove useConcurrentBarriers option
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Description Saam Barati 2019-04-18 11:52:22 PDT 
...
Comment 1 Saam Barati 2019-04-18 11:55:36 PDT 
Created attachment 367741 [details]
patch
Comment 2 Michael Saboff 2019-04-18 11:58:05 PDT 
Comment on attachment 367741 [details]
patch

r=me
Comment 3 Yusuke Suzuki 2019-04-18 11:59:44 PDT 
r=me too. Now, we always use FencedStoreBarrier. So I think we can drop StoreBarrier code :)
Comment 4 Yusuke Suzuki 2019-04-18 12:00:09 PDT 
(In reply to Yusuke Suzuki from comment #3)
> r=me too. Now, we always use FencedStoreBarrier. So I think we can drop
> StoreBarrier code :)

Ah, no, ignore it.
Comment 5 Saam Barati 2019-04-18 12:08:48 PDT 
(In reply to Yusuke Suzuki from comment #3)
> r=me too. Now, we always use FencedStoreBarrier. So I think we can drop
> StoreBarrier code :)

I originally thought that too but came to the same conclusion you did.
Comment 6 WebKit Commit Bot 2019-04-18 13:44:53 PDT 
Comment on attachment 367741 [details]
patch

Clearing flags on attachment: 367741

Committed r244433: <https://trac.webkit.org/changeset/244433>
Comment 7 WebKit Commit Bot 2019-04-18 13:44:55 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-04-18 13:45:22 PDT 
<rdar://problem/50026980>