Bug 197043

Summary:

Adopt different scroll view flashing SPI

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, ggaren, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Tim Horton 2019-04-17 16:59:21 PDT

Adopt different scroll view flashing SPI

Comment 1 Tim Horton 2019-04-17 16:59:32 PDT

Created attachment 367699 [details]
Patch

Comment 2 Tim Horton 2019-04-17 16:59:34 PDT

<rdar://problem/49996476>

Comment 3 Geoffrey Garen 2019-04-17 17:02:44 PDT

Comment on attachment 367699 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367699&action=review

r=me

> Source/WebKit/Platform/spi/ios/UIKitSPI.h:347
> +- (void)_flashScrollIndicatorsPersistingPreviousFlashes;

Should we #if this too?

Comment 4 Tim Horton 2019-04-17 17:03:28 PDT

(In reply to Geoffrey Garen from comment #3)
> Comment on attachment 367699 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=367699&action=review
> 
> r=me
> 
> > Source/WebKit/Platform/spi/ios/UIKitSPI.h:347
> > +- (void)_flashScrollIndicatorsPersistingPreviousFlashes;
> 
> Should we #if this too?

🤷‍♂️

Comment 5 WebKit Commit Bot 2019-04-17 17:42:41 PDT

Comment on attachment 367699 [details]
Patch

Clearing flags on attachment: 367699

Committed r244414: <https://trac.webkit.org/changeset/244414>

Comment 6 WebKit Commit Bot 2019-04-17 17:42:43 PDT

All reviewed patches have been landed.  Closing bug.