Bug 197043

Summary: Adopt different scroll view flashing SPI
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, ggaren, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Tim Horton
Reported 2019-04-17 16:59:21 PDT
Adopt different scroll view flashing SPI
Attachments
Patch (3.72 KB, patch)
2019-04-17 16:59 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2019-04-17 16:59:32 PDT
Created attachment 367699 [details] Patch
Tim Horton
Comment 2 2019-04-17 16:59:34 PDT
<rdar://problem/49996476>
Geoffrey Garen
Comment 3 2019-04-17 17:02:44 PDT
Comment on attachment 367699 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367699&action=review r=me > Source/WebKit/Platform/spi/ios/UIKitSPI.h:347 > +- (void)_flashScrollIndicatorsPersistingPreviousFlashes; Should we #if this too?
Tim Horton
Comment 4 2019-04-17 17:03:28 PDT
(In reply to Geoffrey Garen from comment #3) > Comment on attachment 367699 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=367699&action=review > > r=me > > > Source/WebKit/Platform/spi/ios/UIKitSPI.h:347 > > +- (void)_flashScrollIndicatorsPersistingPreviousFlashes; > > Should we #if this too? 🤷‍♂️
WebKit Commit Bot
Comment 5 2019-04-17 17:42:41 PDT
Comment on attachment 367699 [details] Patch Clearing flags on attachment: 367699 Committed r244414: <https://trac.webkit.org/changeset/244414>
WebKit Commit Bot
Comment 6 2019-04-17 17:42:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.