Bug 197037

Summary:

REGRESSION (r241988): Switching tabs is slow

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, cdumez, commit-queue, simon.fraser, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Tim Horton 2019-04-17 15:37:11 PDT

REGRESSION (r241988): Switching tabs is slow

Comment 1 Tim Horton 2019-04-17 15:37:32 PDT

Created attachment 367688 [details]
Patch

Comment 2 Tim Horton 2019-04-17 15:37:34 PDT

<rdar://problem/49951473>

Comment 3 Simon Fraser (smfr) 2019-04-17 15:49:22 PDT

Comment on attachment 367688 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367688&action=review

> Source/WebKit/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:125
> -    process().connection()->waitForAndDispatchImmediately<Messages::WebPageProxy::DidUpdateActivityState>(m_identifier.toUInt64(), activityStateUpdateTimeout, IPC::WaitForOption::InterruptWaitingIfSyncMessageArrives);
> +    process().connection()->waitForAndDispatchImmediately<Messages::WebPageProxy::DidUpdateActivityState>(m_webPageProxy.pageID(), activityStateUpdateTimeout, IPC::WaitForOption::InterruptWaitingIfSyncMessageArrives);

Type safety FTW

Comment 4 WebKit Commit Bot 2019-04-17 16:33:25 PDT

Comment on attachment 367688 [details]
Patch

Clearing flags on attachment: 367688

Committed r244410: <https://trac.webkit.org/changeset/244410>

Comment 5 WebKit Commit Bot 2019-04-17 16:33:27 PDT

All reviewed patches have been landed.  Closing bug.