Bug 197021

Summary:

Display name is empty when getting credentials with the WebKit API.

Product:

WebKit

Reporter:

Per Arne Vollan <pvollan>

Component:

WebKit Misc.

Assignee:

Per Arne Vollan <pvollan>

Status:

NEW ---

Severity:

Normal

CC:

achristensen, bfulgham, rniwa, webkit-bug-importer, wilander

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	pvollan: review?

Description Per Arne Vollan 2019-04-17 10:55:26 PDT

When getting credentials with -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:], the display name is empty.

Comment 1 Radar WebKit Bug Importer 2019-04-17 10:56:58 PDT

<rdar://problem/49983718>

Comment 2 Per Arne Vollan 2019-04-17 11:01:35 PDT

Created attachment 367651 [details]
Patch

Comment 3 Ryosuke Niwa 2019-04-19 12:54:28 PDT

Comment on attachment 367651 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367651&action=review

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:361
> +                if (!displayName)
> +                    continue;

It doesn't seem right to skip the entry just because we're missing the display name??

Comment 4 Per Arne Vollan 2019-04-19 13:57:04 PDT

(In reply to Ryosuke Niwa from comment #3)
> Comment on attachment 367651 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=367651&action=review
> 
> > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:361
> > +                if (!displayName)
> > +                    continue;
> 
> It doesn't seem right to skip the entry just because we're missing the
> display name??

That makes sense. I will update the patch. Thanks for reviewing!

Comment 5 Per Arne Vollan 2019-04-19 14:21:28 PDT

Created attachment 367826 [details]
Patch