Bug 197016

Summary:

Rename "supported-color-schemes" to "color-scheme"

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

CSS

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, ews-watchlist, rniwa, ryanhaddad, simon.fraser, timothy, webkit-bug-importer

Priority:

Keywords:

BrowserCompat, InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

193931

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews101 for mac-highsierra	none
Patch	none
Patch	none

Simon Fraser (smfr)

Reported 2019-04-17 09:32:46 PDT

The proposal at https://lilles.github.io/specs/supported-color-schemes.html is changing to that in https://github.com/w3c/csswg-drafts/issues/3807

Attachments
Patch (128.86 KB, patch) 2019-04-17 13:56 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Patch (129.90 KB, patch) 2019-04-17 14:07 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-highsierra (3.35 MB, application/zip) 2019-04-17 15:13 PDT, EWS Watchlist	no flags	Details
Patch (131.82 KB, patch) 2019-04-17 15:20 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Patch (132.55 KB, patch) 2019-04-17 15:33 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2019-04-17 09:35:08 PDT

<rdar://problem/49980259>

Timothy Hatcher

Comment 2 2019-04-17 13:56:03 PDT Comment hidden (obsolete)

Created attachment 367675 [details] Patch

Simon Fraser (smfr)

Comment 3 2019-04-17 13:56:59 PDT Comment hidden (obsolete)

Comment on attachment 367675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367675&action=review > Source/WebCore/ChangeLog:9 > + Reviewed by NOBODY (OOPS!). > + > + Tests: css-dark-mode/color-schemes-css.html Some word here, please, with spec links. Please also tell me if you decided to keep support for the old name.

Timothy Hatcher

Comment 4 2019-04-17 14:07:45 PDT Comment hidden (obsolete)

Created attachment 367677 [details] Patch

Simon Fraser (smfr)

Comment 5 2019-04-17 14:11:35 PDT Comment hidden (obsolete)

Comment on attachment 367677 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367677&action=review > Source/WebCore/ChangeLog:22 > + Changed `supported-color-schemes` to `color-schemes` to follow the spec changes > + being tracked by: https://github.com/w3c/csswg-drafts/issues/3807 > + > + The old `supported-color-schemes` is now an alias of `color-schemes` for compatability. This should go above the "Tests" section. > Source/WebCore/css/CSSProperties.json:5980 > + "aliases": [ > + "supported-color-schemes" > + ], > + "converter": "ColorSchemes", Do we have "status" text that says that it's in progress?

EWS Watchlist

Comment 6 2019-04-17 15:13:29 PDT Comment hidden (obsolete)

Comment on attachment 367677 [details] Patch Attachment 367677 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11905969 New failing tests: fast/css/style-enumerate-properties.html

EWS Watchlist

Comment 7 2019-04-17 15:13:31 PDT Comment hidden (obsolete)

Created attachment 367684 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6

Timothy Hatcher

Comment 8 2019-04-17 15:20:57 PDT Comment hidden (obsolete)

Created attachment 367686 [details] Patch

Timothy Hatcher

Comment 9 2019-04-17 15:33:09 PDT

Created attachment 367687 [details] Patch

WebKit Commit Bot

Comment 10 2019-04-17 16:15:07 PDT

Comment on attachment 367687 [details] Patch Clearing flags on attachment: 367687 Committed r244408: <https://trac.webkit.org/changeset/244408>

WebKit Commit Bot

Comment 11 2019-04-17 16:15:09 PDT

All reviewed patches have been landed. Closing bug.

Ryan Haddad

Comment 12 2019-04-18 09:39:30 PDT

These two tests are failing on High Sierra (looks like a rebeaseline?): css-dark-mode/older-systems/color-scheme-css.html css-dark-mode/older-systems/color-scheme-meta.html https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r244423%20(10736)/results.html fast/css/style-enumerate-properties.html is failing on Windows: https://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r244423%20(2134)/results.html

Timothy Hatcher

Comment 13 2019-04-18 13:50:30 PDT

(In reply to Ryan Haddad from comment #12) > These two tests are failing on High Sierra (looks like a rebeaseline?): > > css-dark-mode/older-systems/color-scheme-css.html > css-dark-mode/older-systems/color-scheme-meta.html > > https://build.webkit.org/results/ > Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r244423%20(10736)/results. > html > > fast/css/style-enumerate-properties.html is failing on Windows: > https://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/ > r244423%20(2134)/results.html Fixed in https://trac.webkit.org/changeset/244430/webkit

Note You need to log in before you can comment on or make changes to this bug.