Summary: | [ews-build] Use singular verb in failure description in case of single api test failure | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aakash_jain, ap, commit-queue, dewei_zhu, lforschler, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Aakash Jain
2019-04-17 08:59:41 PDT
Created attachment 367633 [details]
Patch
Comment on attachment 367633 [details]
Patch
I think we have a webkitpy pluralize function. This is pretty lightweight, so so don't expect you to import webkitpy, but I'm curious if the logic you used was similar?
Comment on attachment 367633 [details] Patch > I think we have a webkitpy pluralize function. This is pretty lightweight, > so so don't expect you to import webkitpy, but I'm curious if the logic you > used was similar? The logic is similar. webkitpy method (https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/tool/grammar.py#L41) is little more generic and take care of whether to append 's' vs 'es'. I don't think we need to make a generic function here. Comment on attachment 367633 [details] Patch Clearing flags on attachment: 367633 Committed r244504: <https://trac.webkit.org/changeset/244504> All reviewed patches have been landed. Closing bug. |