RESOLVED FIXED197013
[ews-build] Use singular verb in failure description in case of single api test failure 
https://bugs.webkit.org/show_bug.cgi?id=197013
Summary [ews-build] Use singular verb in failure description in case of single api te...
Aakash Jain
Reported 2019-04-17 08:59:41 PDT
When there is only 1 api test failure, currently the failure string reads: 'Found 1 new API Tests failures'. It should be singular for single failure. e.g.: https://ews-build.webkit.org/#/builders/3/builds/670
Attachments
Patch (2.13 KB, patch)
2019-04-17 09:10 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-04-17 09:10:18 PDT
Created attachment 367633 [details] Patch
Lucas Forschler
Comment 2 2019-04-17 09:15:10 PDT
Comment on attachment 367633 [details] Patch I think we have a webkitpy pluralize function. This is pretty lightweight, so so don't expect you to import webkitpy, but I'm curious if the logic you used was similar?
Aakash Jain
Comment 3 2019-04-22 06:06:19 PDT
Comment on attachment 367633 [details] Patch > I think we have a webkitpy pluralize function. This is pretty lightweight, > so so don't expect you to import webkitpy, but I'm curious if the logic you > used was similar? The logic is similar. webkitpy method (https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/tool/grammar.py#L41) is little more generic and take care of whether to append 's' vs 'es'. I don't think we need to make a generic function here.
WebKit Commit Bot
Comment 4 2019-04-22 11:29:45 PDT
Comment on attachment 367633 [details] Patch Clearing flags on attachment: 367633 Committed r244504: <https://trac.webkit.org/changeset/244504>
WebKit Commit Bot
Comment 5 2019-04-22 11:29:47 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-04-22 11:30:32 PDT
<rdar://problem/50100796>
Note You need to log in before you can comment on or make changes to this bug.