Summary: | AX: HTML datalist accessibility is not exposed by WebKit | ||
---|---|---|---|
Product: | WebKit | Reporter: | James Craig <jcraig> |
Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | aboxhall, andresg_22, apinheiro, cfleizach, commit-queue, dmazzoni, ews-watchlist, jdiggs, rniwa, samuel_white, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | All | ||
OS: | All | ||
Attachments: |
Description
James Craig
2019-04-16 18:30:56 PDT
Created attachment 373744 [details]
Patch
Comment on attachment 373744 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373744&action=review > Source/WebCore/accessibility/AccessibilityObject.cpp:2795 > + RefPtr<Element> element = this->element(); auto > Source/WebCore/accessibility/AccessibilityObject.cpp:2799 > + RefPtr<Element> datalist = element->treeScope().getElementById(datalistId); auto > Source/WebCore/accessibility/AccessibilityObject.cpp:2800 > + return (datalist && is<HTMLDataListElement>(datalist)); the datalist pointer check seems like it might not necessary since is<HTMLDataListElement> should handle the null Comment on attachment 373744 [details] Patch Attachment 373744 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12700457 New failing tests: accessibility/datalist.html Created attachment 373750 [details]
Archive of layout-test-results from ews100 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 373744 [details] Patch Attachment 373744 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12700741 New failing tests: accessibility/datalist.html Created attachment 373766 [details]
Archive of layout-test-results from ews116 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 373767 [details]
Patch
(In reply to chris fleizach from comment #3) > Comment on attachment 373744 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=373744&action=review > > > Source/WebCore/accessibility/AccessibilityObject.cpp:2795 > > + RefPtr<Element> element = this->element(); > > auto > Thought that RefPtr does some referencing counting on the pointer it holds and thus it would be better to type it explicitly. Never know what these functions that return a naked pointer are doing behind the scene. > > Source/WebCore/accessibility/AccessibilityObject.cpp:2799 > > + RefPtr<Element> datalist = element->treeScope().getElementById(datalistId); > > auto > Changed this one to auto but feel that is an example of auto abuse since it is harder to figure out the type of datalist from the initialization on the right hand side than actually typing the variable explicitly. > > Source/WebCore/accessibility/AccessibilityObject.cpp:2800 > > + return (datalist && is<HTMLDataListElement>(datalist)); > > the datalist pointer check seems like it might not necessary since > is<HTMLDataListElement> should handle the null Done. Created attachment 373793 [details]
Patch
#if for datalist feature availability. Comment on attachment 373793 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373793&action=review > LayoutTests/ChangeLog:9 > + * accessibility/datalist-expected.txt: Added. will probably need TestExpectation changes to platforms not supporting datalist also I suspect that other platforms have not implemented popupValue for WKTR and DRT so this test will probably fail on that (GTK) Comment on attachment 373793 [details] Patch Attachment 373793 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12703171 New failing tests: accessibility/datalist.html Created attachment 373799 [details]
Archive of layout-test-results from ews101 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 373793 [details] Patch Attachment 373793 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12703320 New failing tests: accessibility/datalist.html Created attachment 373807 [details]
Archive of layout-test-results from ews112 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 373810 [details]
Patch
Updated TestExpectations for platforms that have no support for datalist. Comment on attachment 373810 [details] Patch Clearing flags on attachment: 373810 Committed r247295: <https://trac.webkit.org/changeset/247295> All reviewed patches have been landed. Closing bug. |